Repository navigation
fix: compile deterministic routes and diagnose ambiguous paths - #13
Merged
WilliamRagstad merged 3 commits intoOct 25, 2026
Merged
WilliamRagstad merged 3 commits into
WilliamRagstad merged 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route selection previously sorted only by length after hash-map iteration, so a generic route could hide a literal one. Compile a deterministic table using left-to-right literal > parameter > wildcard precedence. Reject equivalent route shapes with both source locations and warn about crossing overlaps. Match complete paths and keep matching data in Rust until the owning V8 runtime is selected.
PR 2 of 4; depends on #12. Refs #8. Documents exact matching, wildcard, method, and raw-string parameter behavior. Bodyless write routes are valid, fixing a missing-body diagnostic panic.
Validation:
cargo test --locked— 4 passed, including reversed declaration/module order, nested locations, method separation, wildcard fallbacks, missing segments, and duplicate/ambiguous route diagnostics.