Skip to content

Extend ssr.noExternal with CJS dependency closure #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webstackdev merged 1 commit into from
Aug 10, 2026
Merged

Extend ssr.noExternal with CJS dependency closure #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions astro.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,15 @@ export default defineConfig({
* Bundle the sanitizer and its parser dependency chain into the ESM
* server output so no runtime require() of these packages occurs.
*
* The sanitizer's CommonJS runtime dependencies must be bundled for the
* same reason. Rolldown emits externalized require() calls through a
* createRequire() helper imported from a shared runtime chunk, and
* @vercel/nft's static analysis cannot follow that indirection across
* module boundaries β€” untraced packages are absent from the deployed
* function and crash every action cold start with MODULE_NOT_FOUND.
* Bundling the full dependency closure (launder -> dayjs, postcss ->
* nanoid/picocolors/source-map-js) leaves no runtime require() behind.
*
* Build-only: in the dev server, Vite's SSR module runner evaluates
* noExternal'd CommonJS packages as ESM, crashing the same action with
* "ReferenceError: require is not defined". When the chain is
Expand All @@ -214,6 +223,16 @@ export default defineConfig({
'domhandler',
'domutils',
'entities',
'deepmerge',
'escape-string-regexp',
'is-plain-object',
'launder',
'dayjs',
'parse-srcset',
'postcss',
'nanoid',
'picocolors',
'source-map-js',
]
: [],
},
Expand Down
Loading