Bugfix/e2e stress test fixes - #495
Merged
Merged
Conversation
…elative ./… paths so the only alias use that remains is from the spec files themselves, extend BasePage.waitForPageLoad() with a requireNext option so callers can specifically wait for the next astro:page-load event
…ts (defaults to DEV_SERVER_PORT or 4321) and wired it into vite.server.hmr.clientPort so Vite instructs the browser to negotiate HMR websockets through the same externally exposed port Astro serves on
Dependency ReviewThe following issues were found:
|
…ters out known non-actionable Firefox/Vite HMR websocket noise ('WebSocket closed without opened') before asserting pageErrors().length. Added isIgnorablePageError() helper with documentation.
…p so downstream steps can see whether coverage files were generated
…ld-and-test.yml so CI runs npm run sync before TypeScript checks, typed rss.xml.ts by importing CollectionEntry and annotating the article parameter in the RSS item map to satisfy noImplicitAny
…o record the value of , plus dev/e2e flags, whenever the SW logic runs
…ts and re-ran the WebKit theme picker suite; no policy-check cancellations observed, but logs now capture sufficient context if the flake returns
…icy-version to use page fixture instead of dynamic imports
…e eliminated the socket hang
… to disable on WebKit
…s to push migrations to Suprabase
… add actions lint step and script
…alled Ruby CLI on GitHub Runners
…n used on GitHub Actions Test workflow
… instead of the Postgres-meta sidecar
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 23146611 | Triggered | Generic Password | 4fa4135 | .github/workflows/test.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…ests in Test action workflow, remove gating from deployment for e2e tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
E2E Stress Runs
Type of Change