-
Notifications
You must be signed in to change notification settings - Fork 0
Fix CI type error #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix CI type error #446
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2acf463
Fix CI type error
webstackdev 17ac0b9
Move Sentry sourcemap generation to Vercel from GitHub Actions
webstackdev 53986eb
Fix code and JSON lint errors
webstackdev d4ce81e
Fix mocking errors with upgrade to vitest
webstackdev cff24a7
Remove astro styling config plugin in favor of stylelint official plu…
webstackdev 319d67a
Update stylelint config plugin, config settings, and fix style errors…
webstackdev 2c72f32
Add lint tasks to Husky pre-commit hook
webstackdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Type declaration for generated pages.json file | ||
| * This file is generated during the build process | ||
| */ | ||
|
|
||
| type PageData = | ||
| | string | ||
| | { articles: string[] } | ||
| | { 'case-studies': string[] } | ||
| | { downloads: string[] } | ||
| | { services: string[] } | ||
| | { 'social-shares': string[] } | ||
| | { stories: string[] } | ||
| | { tags: string[] } | ||
|
|
||
| declare const pagesData: PageData[] | ||
| export default pagesData | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| [ | ||
| "about", | ||
| { | ||
| "articles": [ | ||
| "getting-started-with-astro", | ||
| "typescript-best-practices", | ||
| "useful-vs-code-extensions", | ||
| "writing-library-code" | ||
| ] | ||
| }, | ||
| { | ||
| "case-studies": [ | ||
| "division-15", | ||
| "ecommerce-modernization", | ||
| "english-first", | ||
| "enterprise-api-platform", | ||
| "labcorp", | ||
| "us-logistics" | ||
| ] | ||
| }, | ||
| "contact", | ||
| "cookies", | ||
| { | ||
| "downloads": [ | ||
| "api-tool-consolidation-whitepaper", | ||
| "identity-security-for-dummies", | ||
| "lakehouse-analytics-guide", | ||
| "observability-benefits-guide", | ||
| "ransomware-recovery-kit" | ||
| ] | ||
| }, | ||
| "offline", | ||
| "privacy", | ||
| { | ||
| "services": ["create-custom-font-sets", "overview"] | ||
| }, | ||
| { | ||
| "social-shares": ["template"] | ||
| }, | ||
| { | ||
| "tags": [ | ||
| "apiDesign", | ||
| "cms", | ||
| "code", | ||
| "crm", | ||
| "graphql", | ||
| "online-learning", | ||
| "react", | ||
| "services", | ||
| "typescript" | ||
| ] | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| /* eslint-disable jsdoc/no-multi-asterisks */ | ||
| /** | ||
| * Type definitions for remark-abbr | ||
| * | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PageData type definition is too rigid with hardcoded property names. This forces type definition updates whenever new page categories are added. Consider using a more flexible type:
type PageData = string | Record<string, string[]>to allow any category name.