Hand the failed-job provider JSON on igbinary sites - #3
Merged
Merged
Conversation
…irst stream's Redis returns up to COUNT entries per stream for a multi-stream XREADGROUP. The parser kept the first stream's entry and dropped the rest on the floor, leaving them delivered-but-unprocessed in the consumer's PEL until retry_after allowed a steal. Buffer the extra entries per worker and serve them before the next read.
The JobFailed listener passed the raw igbinary body to queue.failer, and database-uuids reads json_decode($payload, true)['uuid'], so every permanent failure logged 'failed-jobs log threw: Trying to access array offset on null' and failed_jobs stayed empty. WorkerProcess::failerPayload() re-encodes igbinary bodies as JSON and passes JSON through untouched, so queue:failed and queue:retry work with TORQUE_SERIALIZER=igbinary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scrpr.nl (igbinary serializer) logged
[torque:worker] failed-jobs log threw: Trying to access array offset on nullonce per permanent failure (9,765 lines). TheJobFailedlistener handed the raw igbinary body toqueue.failer, anddatabase-uuidsdoesjson_decode($payload, true)['uuid']. Harmless for processing, butfailed_jobsstayed empty soqueue:failed/queue:retrydid nothing on igbinary sites.What
WorkerProcess::failerPayload()re-encodes an igbinary body as JSON and passes JSON through untouched. A retried job is transcoded back to igbinary on push by the existingtranscodeIncomingPayload(), so the full round trip works.Chosen over skipping the failer for non-JSON serializers, which would have silenced the line but kept
failed_jobsempty.Verified
DatabaseUuidFailedJobProvideron in-memory sqlite with both bodies, including one that reproduces the exact production error with the raw body