fix: hand every delivered XREADGROUP entry to a Fiber - #2
Merged
Merged
Conversation
…irst stream's Redis returns up to COUNT entries per stream for a multi-stream XREADGROUP. The parser kept the first stream's entry and dropped the rest on the floor, leaving them delivered-but-unprocessed in the consumer's PEL until retry_after allowed a steal. Buffer the extra entries per worker and serve them before the next read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XREADGROUP ... COUNT 1 STREAMS a b creturns up to one entry per stream;parseXreadgroupResponse()only returned the first stream's entry, so the others were delivered (PEL) but never processed untilretry_afterlet another worker steal them.readNextMessage()drains before the next read. Same path for the periodic own-PEL read.slowSyncPersist parts waited 30 min each whiledefaultwas busy, throughput on the RDW sync collapsed to bursts.Test plan
tests/Unit/Worker/WorkerPrefetchTest.php(4 cases: buffering, skipping payload-less entries, empty reply, buffer served before Redis)🤖 Generated with Claude Code
https://claude.ai/code/session_014vbDzqsY85c7hEPRSxM3XK