Repository navigation
Validate the NuGet package and test the demo app against it - #101
Merged
Merged
Conversation
- Enable package validation with 1.4.0 as the baseline: packing now fails on API differences between target frameworks or breaking changes since the last release. The two existing, intentional differences are recorded in CompatibilitySuppressions.xml. - DemoApp can reference the packed .nupkg instead of the project (UseRotativaPackage + RotativaPackageVersion), restored through package-test.nuget.config so the package comes only from the local feed. - Dockerfile: USE_ROTATIVA_PACKAGE=true packs the library, builds the demo app against the package and checks deps.json confirms it. - CI runs the test job for both project and package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #100. This commit was pushed after #100 was merged, so it wasn't included.
Summary
dotnet pack(and every build, since the project packs on build) now fails on API differences between target frameworks and on breaking changes since the last published version, with 1.4.0 as the baseline.CompatibilitySuppressions.xml. The extension class is namedRotativaAppBuilderExtensionson net5.0 butMvcServiceCollectionExtensionson net6.0+.RotativaConfiguration.Setup(IHostingEnvironment, ...)exists only in the netstandard2.0 build.PackageValidationBaselineVersionto the version just published..nupkg.UseRotativaPackage=trueplusRotativaPackageVersion).package-test.nuget.config, soRotativa.AspNetCorecan only come from the localartifacts/packagesfolder.docker build --build-arg USE_ROTATIVA_PACKAGE=true ...packs the library, builds the DemoApp against the package, and checks.deps.jsonto confirm the package was used.Test plan
CP0002against 1.4.0. With the change reverted, the build passes..deps.jsonshows"type": "package"and"type": "project"respectively.🤖 Generated with Claude Code