style: Put ButtonThemesView buttons in ColumnLayout containers - #1057
Open
bbrennanbasis wants to merge 2 commits into
Open
bbrennanbasis wants to merge 2 commits into
bbrennanbasis wants to merge 2 commits into
Conversation
bbrennanbasis
requested review from
EHandtkeBasis,
MatthewHawkins,
gosteenBASIS,
hyyan and
laurenic0l
as code owners
July 14, 2026 22:47
bbrennanbasis
added
the
status: waiting-for-review
hyyan
requested changes
Jul 31, 2026
hyyan
left a comment
hyyan
left a comment
Member
There was a problem hiding this comment.
I'd prefer all button themes to be visible at the same time, current appraoch adds some noise to the code. We could try using a CSS grid that displays 3 buttons per row and lets them wrap, with the page scrolling as needed.
hyyan
marked this pull request as draft
July 31, 2026 14:42
bbrennanbasis
changed the title
bbrennanbasis
marked this pull request as ready for review
August 3, 2026 21:29
Member
Author
|
@hyyan please see the changes I've pushed, it puts the buttons in a grid. |
bbrennanbasis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Button themes sample by condensing the displayed buttons into an infinite carousel, but displays all the buttons if the viewing screen is wide enough.