Skip to content

fix-php85-deprecation-notice Use new constant in php 8.4 or higher to… #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
func0der wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix-php85-deprecation-notice Use new constant in php 8.4 or higher to… #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98a3dd8
fix-php85-deprecation-notice Use new constant in php 8.4 or higher to…
func0der Jun 1, 2026
7ab8cb8
fix-php85-deprecation-notice Allowlist php8.4 class
func0der Jun 1, 2026
5592f61
fix-php85-deprecation-notice Use constant instead of function call
func0der Jun 1, 2026
1092659
fix-php85-deprecation-notice fix-php-cs-fixer Fix php cs fixer
func0der Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .composer-require-checker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"symbol-whitelist": [
"Doctrine\\Common\\EventSubscriber",
"Doctrine\\DBAL\\Event\\SchemaColumnDefinitionEventArgs",
"Doctrine\\DBAL\\Events"
"Doctrine\\DBAL\\Events",
"PDO\\Mysql"
]
}
2 changes: 0 additions & 2 deletions .github/workflows/fix-cs-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
ref: ${{ github.head_ref }}

- name: Run PHP-CS-Fixer
uses: docker://ghcr.io/php-cs-fixer/php-cs-fixer:3.62.0-php8.3
Expand Down
15 changes: 13 additions & 2 deletions src/Webfactory/Slimdump/Database/Dumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ private function dumpData(Schema\Table $asset, Table $tableConfig): void
} else {
throw new RuntimeException('failed to obtain the wrapped PDO object from the DBAL connection');
}
$pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, false);
$this->controlBufferedQuery($pdo, false);
$actualRows = 0;

$this->outputFormatDriver->beginTableDataDump($asset, $tableConfig);
Expand All @@ -155,7 +155,7 @@ private function dumpData(Schema\Table $asset, Table $tableConfig): void
$this->progressOutput->writeln(\sprintf('<error>Expected %d rows, actually processed %d – verify results!</error>', $numRows, $actualRows));
}

$pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);
$this->controlBufferedQuery($pdo, true);

$this->outputFormatDriver->endTableDataDump($asset, $tableConfig);
}
Expand All @@ -166,4 +166,15 @@ public static function isBlob(Schema\Column $column): bool

return $type instanceof BlobType || $type instanceof BinaryType;
}

private function controlBufferedQuery(PDO $pdo, bool $value): void
{
if (version_compare(\PHP_VERSION, '8.4.0', '<')) {
$pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);

return;
}

$pdo->setAttribute(PDO\Mysql::ATTR_USE_BUFFERED_QUERY, $value);
}
}
Loading