Skip to content

Add autocomplete attribute to email form field #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janopae merged 2 commits into from
Oct 6, 2026
Merged

Add autocomplete attribute to email form field #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d83e3
Add autocomplete attribute to email form field
polarbirke Oct 2, 2026
c12ae9c
Merge branch 'main' into feat-email-autocomplete
janopae Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/StartRegistration/EmailAddressType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public function configureOptions(OptionsResolver $resolver): void
'empty_data' => null,
'required' => true,
'compound' => false,
'attr' => ['autocomplete' => 'email'],
'label' => 'start.registration.label.email.address',
'translation_domain' => 'webfactory-newsletter-registration',
'constraints' => [
Expand Down
7 changes: 7 additions & 0 deletions tests/StartRegistration/EmailAddressTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,13 @@ public function provides_EmailAddress_if_submitted_with_valid_data()
}

#[Test]
public function identifies_input_purpose_for_autofill()
{
$view = $this->form->createView();

$this->assertEquals('email', $view['emailAddress']->vars['attr']['autocomplete']);
}

public function has_translatable_label()
{
$view = $this->form->createView();
Expand Down
Loading