Skip to content

chore: upgrade pnpm 10.32.1 -> 12.5.1 - #112

Merged
dprevost-LMI merged 1 commit into
webdriverio:mainfrom
dprevost-LMI:upgrade-pnpm-12
Sep 22, 2026
Merged

dprevost-LMI merged 1 commit into
webdriverio:mainfrom
dprevost-LMI:upgrade-pnpm-12

Conversation

@dprevost-LMI

Copy link
Copy Markdown
Collaborator

Bumps packageManager (verified hash via corepack use pnpm@12.5.1, not hand-edited), engines.pnpm floor, .cursor/Dockerfile's pinned version, and AGENTS.md's matching prose. pnpm/action-setup in CI reads the packageManager field automatically, so no workflow changes needed.

Also fixes two things this upgrade surfaced:

  • cddl2ts's cli-examples:local/remote scripts called bare pnpm run compile expecting an implicit fallback to the root's compile script. That's not a documented pnpm behavior - it happened to work under pnpm 10 only when nested inside the recursive pnpm -r chain (a cold standalone call fails identically on both 10 and 12, with pnpm 10's own error hinting at the real fix). pnpm 12 removed the nested-context fallback entirely, breaking checks:all. Now uses the explicit pnpm -w run compile, which works on both and doesn't rely on unspecified behavior.
  • .cursor/Dockerfile only COPYed package.json for 4 of the 6 workspace packages (cddl2swift/cddl2kotlin missing) - pre-existing, unrelated to the pnpm bump, but would have broken pnpm install --frozen-lockfile in a fresh Cursor Cloud container today. Added the missing two.

Also includes a safe, verified dependency bump surfaced by pnpm outdated -r: yargs 18.1.0 -> 18.2.0 (in-range for every package's existing ^18.0.0, pnpm update tightened the floor to match).

Full checks:all passes under pnpm 12.5.1. See the follow-up summary for the rest of the outdated-dependency analysis (recast, vitest, @vitest/coverage-v8, release-it) - those need an explicit decision before touching, not included here.

Bumps packageManager (verified hash via `corepack use pnpm@12.5.1`,
not hand-edited), engines.pnpm floor, .cursor/Dockerfile's pinned
version, and AGENTS.md's matching prose. pnpm/action-setup in CI reads
the packageManager field automatically, so no workflow changes needed.

Also fixes two things this upgrade surfaced:
- cddl2ts's cli-examples:local/remote scripts called bare `pnpm run
  compile` expecting an implicit fallback to the root's compile script.
  That's not a documented pnpm behavior - it happened to work under
  pnpm 10 only when nested inside the recursive `pnpm -r` chain (a cold
  standalone call fails identically on both 10 and 12, with pnpm 10's
  own error hinting at the real fix). pnpm 12 removed the nested-context
  fallback entirely, breaking `checks:all`. Now uses the explicit `pnpm
  -w run compile`, which works on both and doesn't rely on unspecified
  behavior.
- .cursor/Dockerfile only COPYed package.json for 4 of the 6 workspace
  packages (cddl2swift/cddl2kotlin missing) - pre-existing, unrelated to
  the pnpm bump, but would have broken `pnpm install --frozen-lockfile`
  in a fresh Cursor Cloud container today. Added the missing two.

Also includes a safe, verified dependency bump surfaced by `pnpm
outdated -r`: yargs 18.1.0 -> 18.2.0 (in-range for every package's
existing ^18.0.0, `pnpm update` tightened the floor to match).

Full checks:all passes under pnpm 12.5.1. See the follow-up summary for
the rest of the outdated-dependency analysis (recast, vitest,
@vitest/coverage-v8, release-it) - those need an explicit decision
before touching, not included here.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR consistently upgrades the repository to pnpm 12.5.1 and updates the generated lockfile.

  • Raises the pnpm engine requirement and aligns Docker and contributor documentation.
  • Makes cddl2ts example scripts explicitly invoke the workspace-root compile.
  • Completes the Docker dependency layer with all workspace manifests.
  • Upgrades yargs from 18.1.0 to 18.2.0 across workspace packages.

Reviews (1) · Last reviewed commit: "chore: upgrade pnpm 10.32.1 -> 12.5.1"

@dprevost-LMI
dprevost-LMI merged commit 79ca980 into webdriverio:main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant