Skip to content

Enable Russian localization - #1036

Open
Mangalushka wants to merge 1 commit into
webadderallorg:mainfrom
Mangalushka:enable-russian-locale
Open

Mangalushka wants to merge 1 commit into
webadderallorg:mainfrom
Mangalushka:enable-russian-locale

Conversation

@Mangalushka

@Mangalushka Mangalushka commented Sep 25, 2026 •

Copy link
Copy Markdown

What

Russian translations have been in the repo since #446 (May), but ru was never added to SUPPORTED_LOCALES, so the bundle is never imported and the language never appears in the picker. This wires it up:

  • src/i18n/config.ts — register ru
  • src/contexts/I18nContext.tsx — import the seven ru namespaces and add them to messages
  • src/components/video-editor/SettingsPanel.tsx — add Русский to APP_LANGUAGE_LABELS
  • src/i18n/locales/ru/settings.json — translate the 22 strings added after the original contribution (the click-effects block and the caption editor rows), which were still English

Checks

  • npm run i18n:check → locale files are structurally consistent
  • No other file in the repo enumerates locales (grepped for pt-BR outside locales/), so this is the whole wiring

Notes

This rebases #691 onto current main (that PR conflicts now, and de has been added since). Credit to @Domanffe for the original enablement and @voinkovpost for the translations. Happy to close this if #691 gets rebased instead.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added Russian as a selectable app language, with translations for click-effect settings and caption-editor actions.

The ru/ locale files have shipped since webadderallorg#446, but "ru" was never added to
SUPPORTED_LOCALES, so the bundle was never imported and Russian never showed
up in the language picker.

Register the locale, wire its namespaces into I18nContext, add the label, and
translate the 22 strings added to settings after the original contribution
(click effects and the caption editor rows). npm run i18n:check passes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: webadderallorg/Recordly/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a36827df-3539-487f-a8f6-56b462a6ddd2

📥 Commits

Reviewing files that changed from the base of the PR and between 1888428 and 904b15d.

📒 Files selected for processing (4)
  • src/components/video-editor/SettingsPanel.tsx
  • src/contexts/I18nContext.tsx
  • src/i18n/config.ts
  • src/i18n/locales/ru/settings.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The application now includes Russian in its supported locales and displays “Русский” in the language selector. Russian bundles are registered for seven namespaces, and selected click-effect and caption-editor strings are translated.

Changes

Russian locale support

Layer / File(s) Summary
Register Russian locale and settings translations
src/i18n/config.ts, src/contexts/I18nContext.tsx, src/components/video-editor/SettingsPanel.tsx, src/i18n/locales/ru/settings.json
The supported locale list and message map include Russian, and the language selector displays “Русский.” Russian translations replace English strings for click-effect controls and caption-editor actions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: webadderall

Merge Risk: ⚪ Minimal · up to 904b1

Russian can be selected and its registered translations are available for the app’s namespaces. The changed settings strings match their corresponding keys, and no concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose, affected files, translation changes, validation command, and implementation notes. It does not follow the repository template and omits explicit Type of Change, R… Add the required template sections. Select the applicable change type, link the related issue or state that none exists, provide screenshots or explain why they are not applicable, document the testing steps, and complete the checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: enabling Russian localization in the application.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose, affected files, translation changes, validation command, and implementation notes. It does not follow the repository template and omits explicit Type of Change, Related Issue(s), Screenshots / Video, and Checklist sections.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant