Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve screen reader output for the Windows recording HUD. Idle controls now expose the selected source and current microphone, webcam, and countdown state. Source results have accessible names and announce loading or an empty list. A stable live region announces recording, paused, and finalizing states while the elapsed timer remains available without being announced every second.
Motivation
Issue #938 reports that recording controls are difficult to operate with a screen reader. This is a focused improvement to the recording setup and HUD. It does not address the timeline or add global shortcuts, which already have separate work in progress.
Type of Change
Related Issue(s)
Refs #938
Screenshots / Video
No visual change.
Testing Guide
Automated checks passed:
npm run typechecknpm run lint(one existing warning inProjectThumbnail.tsx)npm run i18n:checknpx biome format src/components/launch/LaunchWindow.tsx src/components/launch/RecordingControls.tsx src/components/launch/SourceSelector.tsx tests/ui/hud-accessibility.spec.ts tests/ui/hud-layout.spec.tsnpx vitest run electron/hudOverlayWindowOptions.test.tsThe existing
HUD dividers are vertically centeredUI test still fails at its final Projects dashboard assertion after navigating from the HUD to the editor. Its layout assertions pass. This PR does not change dashboard navigation.Manual Windows Narrator and native mouse pass-through checks are pending. On Windows, focus the Recordly HUD from the taskbar, tab through the source, microphone, webcam, countdown, and Record controls, then choose a source and exercise Record, Pause, Resume, and Stop. Confirm that Narrator announces state changes once and that the transparent HUD still passes mouse input through to the recorded app.
Checklist