fix: allow .m4a local media so macOS mic sidecars play - #1026
muhammad-a-dev wants to merge 1 commit into
Conversation
macOS native capture writes mic/system audio as .m4a sidecars. Without .m4a in MEDIA_CONTENT_TYPES, get-local-media-url blocks those paths and the editor/export stay silent even though the files exist on disk. Fixes webadderallorg#1016
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: webadderallorg/Recordly/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe media type map now recognizes ChangesLocal media type support
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The change enables local M4A sidecars while retaining the separate path checks. No material merge-blocking risk is indicated by the supplied context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
On macOS, native capture keeps mic and system audio as
.m4asidecars (recording-*.mic.m4a,recording-*.system.m4a). Those files were rejected byMEDIA_CONTENT_TYPES/isSupportedLocalMediaPath(), soget-local-media-urlblocked them and the editor/export stayed silent even though the audio existed on disk.Reported in #1016 (follow-up to #912).
Fix
".m4a": "audio/mp4"toelectron/mediaTypes.ts(matches how the renderer already treats.m4ainlocalMediaSource.ts).electron/mediaTypes.test.ts.Path allowlisting is unchanged: reads are still scoped by
isAllowedLocalReadPath()/ session directories.Testing
.m4asupport and unsupported extensions.Fixes #1016
Summary by CodeRabbit
.m4aaudio recordings, including microphone and system-audio files. These recordings are now recognized as audio media.