Skip to content

fix(auto-zoom): apply fresh-recording auto-zoom to portrait window captures on macOS #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
untani wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(auto-zoom): apply fresh-recording auto-zoom to portrait window captures on macOS #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/video-editor/timeline/zoomSuggestionUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ describe("shouldAutoApplyFreshRecordingZoomsForSource", () => {
expect(shouldAutoApplyFreshRecordingZoomsForSource(936, 1028, "win32")).toBe(true);
});

it("allows narrow macOS window captures (portrait windows) too", () => {
expect(shouldAutoApplyFreshRecordingZoomsForSource(936, 1028, "darwin")).toBe(true);
expect(shouldAutoApplyFreshRecordingZoomsForSource(1080, 1920, "darwin")).toBe(true);
});

it("does not block when source dimensions are not available yet", () => {
expect(shouldAutoApplyFreshRecordingZoomsForSource()).toBe(true);
});
Expand Down
9 changes: 5 additions & 4 deletions src/components/video-editor/timeline/zoomSuggestionUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ export function shouldAutoApplyFreshRecordingZoomsForSource(
sourceHeight?: number,
platform?: string,
): boolean {
// Window capture on Windows legitimately produces portrait and near-square
// sources. Click telemetry is already normalized to that captured window, so
// its aspect ratio is not a reason to suppress interaction-based zooms.
if (platform === "win32") {
// Window capture on Windows and macOS legitimately produces portrait and
// near-square sources (e.g. recording a single vertical app window). Click
// telemetry is already normalized to that captured window, so its aspect
// ratio is not a reason to suppress interaction-based zooms.
if (platform === "win32" || platform === "darwin") {
return true;
}

Expand Down