[geolocation] fix the accuracyMode test's precise case and coordinate assertions - #61886
Merged
marcoscaceres merged 1 commit intoAug 12, 2026
Conversation
… assertions The second test is named "precise" but requested "approximate" and then asserted that altitude, altitudeAccuracy, heading and speed come back populated, which w3c/geolocation#233 requires to be null for an approximate position. The first test asserted that the emulated latitude, longitude and accuracy come back unchanged, which an implementation that actually coarsens cannot satisfy, and the pull request leaves the coarsened area to the underlying system. Also drops two assignments to an undeclared calledAsync global.
7 tasks
Contributor
|
Indeed, thanks for the fix! LGTM. |
marcoscaceres
enabled auto-merge (squash)
August 12, 2026 14:53
reillyeon
approved these changes
Aug 12, 2026
markafoltz
pushed a commit
to markafoltz/web-platform-tests
that referenced
this pull request
Aug 17, 2026
… assertions (web-platform-tests#61886) The second test is named "precise" but requested "approximate" and then asserted that altitude, altitudeAccuracy, heading and speed come back populated, which w3c/geolocation#233 requires to be null for an approximate position. The first test asserted that the emulated latitude, longitude and accuracy come back unchanged, which an implementation that actually coarsens cannot satisfy, and the pull request leaves the coarsened area to the underlying system. Also drops two assignments to an undeclared calledAsync global.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second test is named
"precise"but requested"approximate", and w3c/geolocation#233 setsaltitude,altitudeAccuracy,headingandspeedto null for an approximate position unconditionally, soenableHighAccuracycannot reinstate them and the test's assertions could not hold; this switches the options to match the test's name.The first test compared the coordinates against the emulated values, which an implementation that coarsens cannot satisfy, since the pull request leaves what counts as a coarsened area to the underlying system; the type checks keep those properties required without dictating their values.
Also drops two assignments to an undeclared
calledAsyncglobal.