chore: update workspace Rslib dependency to 1.0.1 - #1926
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
rstack still resolves Rslib 1.0.0, and stale 1.0.0 lockfile records remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the workspace Rslib dependency from 1.0.0 to 1.0.1 and refreshes lockfile resolutions.
Changes:
- Bumps the
rslibcatalog alias to@rslib/core@1.0.1. - Updates related lockfile entries and
rsbuild-plugin-dtsto 1.0.1.
File summaries
| File | Review notes |
|---|---|
pnpm-workspace.yaml |
Moderate (1 vote): Update the root rstack dependency or add a scoped override so it no longer resolves Rslib 1.0.0. |
pnpm-lock.yaml |
Nit (2 votes): Remove obsolete orphaned Rslib 1.0.0 package and snapshot records. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-workspace.yaml:94
- Also update the root
rstackdependency or add a narrowly scoped override before regenerating the lockfile. Its current snapshot still installs@rslib/core@1.0.0(and thereforersbuild-plugin-dts@1.0.0) atpnpm-lock.yaml:14589-14592, so workspace tooling continues to run against the previous Rslib version despite this catalog change.
'rslib': 'npm:@rslib/core@1.0.1'
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The workspace catalog still resolved the local
rslibalias to@rslib/core@1.0.0even though the workspace packages had been released as 1.0.1. This caused local package development and lockfile resolution to use the previous Rslib version.Changes
Update the workspace
rslibcatalog and regeneratepnpm-lock.yamlso workspace tooling resolves@rslib/core@1.0.1andrsbuild-plugin-dts@1.0.1.Validation
pnpm installpnpm buildpnpm test:unit(185 passed)pnpm test:integration(348 passed; 1 skipped, 1 todo)