Skip to content

chore: update workspace Rslib dependency to 1.0.1 - #1926

Merged
Timeless0911 merged 2 commits into
mainfrom
david/upgrade-rslib-1.0.1
Sep 15, 2026
Merged

Timeless0911 merged 2 commits into
mainfrom
david/upgrade-rslib-1.0.1

Conversation

@Timeless0911

Copy link
Copy Markdown
Contributor

Motivation

The workspace catalog still resolved the local rslib alias to @rslib/core@1.0.0 even though the workspace packages had been released as 1.0.1. This caused local package development and lockfile resolution to use the previous Rslib version.

Changes

Update the workspace rslib catalog and regenerate pnpm-lock.yaml so workspace tooling resolves @rslib/core@1.0.1 and rsbuild-plugin-dts@1.0.1.

Validation

  • pnpm install
  • pnpm build
  • pnpm test:unit (185 passed)
  • pnpm test:integration (348 passed; 1 skipped, 1 todo)

Copilot AI lite review requested due to automatic review settings September 15, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

rstack still resolves Rslib 1.0.0, and stale 1.0.0 lockfile records remain.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the workspace Rslib dependency from 1.0.0 to 1.0.1 and refreshes lockfile resolutions.

Changes:

  • Bumps the rslib catalog alias to @rslib/core@1.0.1.
  • Updates related lockfile entries and rsbuild-plugin-dts to 1.0.1.
File summaries
File Review notes
pnpm-workspace.yaml Moderate (1 vote): Update the root rstack dependency or add a scoped override so it no longer resolves Rslib 1.0.0.
pnpm-lock.yaml Nit (2 votes): Remove obsolete orphaned Rslib 1.0.0 package and snapshot records.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file

Suppressed comments (1)

pnpm-workspace.yaml:94

  • Also update the root rstack dependency or add a narrowly scoped override before regenerating the lockfile. Its current snapshot still installs @rslib/core@1.0.0 (and therefore rsbuild-plugin-dts@1.0.0) at pnpm-lock.yaml:14589-14592, so workspace tooling continues to run against the previous Rslib version despite this catalog change.
  'rslib': 'npm:@rslib/core@1.0.1'
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pnpm-lock.yaml
@Timeless0911
Timeless0911 merged commit a0aae93 into main Sep 15, 2026
11 checks passed
@Timeless0911
Timeless0911 deleted the david/upgrade-rslib-1.0.1 branch September 15, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants