fix(WCD-6067): exit auth_required on rejected login - #6
Merged
m3talux merged 2 commits intoSep 25, 2026
Merged
Conversation
A rejected token exchange during login returned a bare tokenError with no error code, defaulting to internal_error/exit 1; a genuine rejected grant (4xx, not 429) now maps to auth_required/exit 3, matching every other not-signed-in case. 429/5xx from the token endpoint stay unclassified/transient, mirroring the same distinction the refresh path (RequireToken) already draws, rather than misreporting a rate-limited or momentarily-down auth server as "not authenticated". --timeout without --wait on cluster create was silently accepted and ignored despite its own help text; it now fails at invocation with validation_failed/exit 2 before any request is made. Guide updated to name the new login-exchange-rejected outcome alongside the existing not-signed-in/timeout ones.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
iangregson
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issue
WCD-6067
Related PRs
N/A
Usage
$ wcloud cluster create --timeout 5s -o json
exit 2, code validation_failed
$ wcloud auth login
token endpoint rejects the code, exit 3, code auth_required