fix(⬆️): upgrade to chrome/154 and SPM support - #471
Conversation
|
Had a look — the distribution half looks right to me. A zipped xcframework with a published SHA-256, consumed by The one thing I'd flag is this comment in
That's no longer the case as of 0.87. A library that ships its own Three smaller things in the current approach:
One thing worth building in now, while you're in this file: Skia Graphite and WebGPU have to link the exact same Dawn. The podspec enforces that today by comparing Happy to help with any of this. |
…E to chrome-m154 chrome-m154 does not contain the upstream fix, so the workaround stays. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- Resolve the Pods directory from the package location instead of relying on PODS_ROOT/SRCROOT, which xcodebuild never exports and which SwiftPM's manifest cache can freeze as empty. Drop the CI env workaround. - Add the Skia Graphite Dawn version check to Package.swift (the podspec prepare-time check has no SwiftPM equivalent); bake the Dawn release tag into the generated manifest for it. - Refuse RNWGPU_USE_SPM together with USE_FRAMEWORKS in the podspec: the manifest reads the static-library Pods/Headers/Public layout. - Express the folly defines as .define instead of unsafeFlags; only the Pods include paths remain unsafe. - Correct the manifest comment: React Native 0.87 has SwiftPM autolinking for self-managed packages; this manifest still targets the CocoaPods header model and says so. Document the constraints in the install docs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.