Skip to content

fix(pr-agent): discriminate the concurrency group by event and by pr/issue #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yakimoto wants to merge 1 commit into from
Closed

fix(pr-agent): discriminate the concurrency group by event and by pr/issue #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/pr-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,18 @@ permissions:
pull-requests: write
contents: read

# Concurrency is evaluated at WORKFLOW level, before any job `if:` — so a run that
# the reusable lane would skip has already entered this group and evicted whatever
# was in it. PRs and Issues also share ONE number sequence. The group therefore
# needs both discriminators, and neither is redundant:
# - `event_name` keeps a push-triggered `pull_request` review from being
# cancelled by an `issue_comment` on the same PR.
# - the `pr`/`issue` kind keeps `issue_comment` on PR #30 from colliding with
# `issue_comment` on Issue #30, which `event_name` alone does not separate.
# Measured fleet-wide: 118 of 137 callers carried the undiscriminated key
# (wave-pen#386, #420).
concurrency:
group: pr-agent-${{ github.event.pull_request.number || github.event.issue.number || github.ref }}
group: pr-agent-${{ github.event_name }}-${{ (github.event.pull_request.number || github.event.issue.pull_request) && 'pr' || 'issue' }}-${{ github.event.pull_request.number || github.event.issue.number || github.ref }}
cancel-in-progress: true

jobs:
Expand Down
Loading