Skip to content

chore(deps): update dependency js-yaml to v4.3.1 [security] #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency js-yaml to v4.3.1 [security] #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 14 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@redocly/cli": "2.40.0",
"js-yaml": "4.1.0",
"js-yaml": "4.3.1",

@devin-ai-integration devin-ai-integration Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Security update to the YAML parser is not applied in the CI pipeline, which still installs the old vulnerable version

The dependency version is raised only in the project manifest (js-yaml bumped to 4.3.1 in package.json:13) while the CI workflow keeps installing the old version explicitly (npm install ... js-yaml@4.1.0 at .github/workflows/foundation-gate.yml:59), so the checks still run with the unpatched parser.
Impact: The advertised security fix does not take effect where the tool is actually used, and the two pinned versions can drift apart silently.

Incomplete version bump across manifest and workflow pin

The PR (and its lockfile update) moves js-yaml from 4.1.0 to 4.3.1 for a security advisory. However the spec-lint job does not use npm ci with the repo manifest for this step; it installs js-yaml@4.1.0 directly before running .github/scripts/assert-refs.mjs (.github/workflows/foundation-gate.yml:58-60), which imports js-yaml at .github/scripts/assert-refs.mjs:36. The pin should be updated to 4.3.1, or better, the step should install from the lockfile (npm ci) so future Renovate bumps propagate automatically.

Prompt for agents 
The js-yaml dependency was bumped from 4.1.0 to 4.3.1 in package.json and package-lock.json for a security advisory, but .github/workflows/foundation-gate.yml (spec-lint job, 'Assert every internal $ref resolves' step) still runs `npm install --no-save --no-audit --no-fund js-yaml@4.1.0` before executing .github/scripts/assert-refs.mjs, so CI keeps using the vulnerable version and the two pins can drift. Either update that hardcoded pin to match package.json, or change the step to install from the committed lockfile (npm ci) so future dependency bumps propagate automatically.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
"openapi-typescript": "7.13.0"
}
}
Loading