fix: resolve ws2_32/oleaut32/wsock32 ordinal imports in imphash (match pefile)

[warpedatom]

Summary by Sourcery

Resolve PE import hash discrepancies by normalizing certain ordinal imports to match pefile/VirusTotal behavior and bump the crate version.

Bug Fixes:

• Ensure imphash resolves ordinal-only imports from ws2_32, wsock32, and oleaut32 to their canonical function names instead of ord, aligning results with pefile and VirusTotal.

Enhancements:

• Introduce a centralized ordinal-to-name lookup table module for ws2_32, wsock32, and oleaut32, shared by imphash computation and display logic, with regression tests to keep it in sync with pefile.

Build:

• Bump the OffsetScan crate version from 0.1.2 to 0.1.3.

Documentation:

• Document the imphash ordinal resolution change and new ordinal tables in the changelog for version 0.1.3.

Tests:

• Add unit tests for the ordinal resolution module to verify behavior against expected ws2_32/wsock32/oleaut32 mappings and edge cases.

[sourcery-ai]

Reviewer's Guide

Imphash calculation for PE imports now resolves ordinal-only imports from ws2_32/wsock32/oleaut32 to their real function names using a new ordinal lookup module, aligning results with pefile/VirusTotal, and the crate version/changelog are updated accordingly.

Sequence diagram for special ordinal resolution in imphash

sequenceDiagram
    participant pe as parse_pe
    participant ord as special_ordinal_name
    participant ws as ws2_32/wsock32/oleaut32

    pe->>pe: detect by_ordinal
    pe->>ord: special_ordinal_name(dll_lower, import.ordinal)
    alt [dll_lower is ws2_32.dll/wsock32.dll/oleaut32.dll]
        ord->>ws: ws2_32(ordinal)/wsock32(ordinal)/oleaut32(ordinal)
        ws-->>ord: function_name
        ord-->>pe: Some(function_name)
        pe->>pe: func = function_name (lowercased)
    else [non-special library or ordinal not in table]
        ord-->>pe: None
        pe->>pe: func = format!("ord{}", import.ordinal)
    end
    pe->>pe: imphash_entries.push(format!("{lib_base}.{func}"))
    pe->>pe: func_display = func.clone()

Loading

File-Level Changes

Change	Details	Files
Resolve special-case ordinal-only imports to real function names during imphash generation to match pefile/VirusTotal behavior.	Detect ordinal-only imports as before using empty name or "ORDINAL " prefix. Lookup ws2_32/wsock32/oleaut32 ordinals via a helper and fall back to "ord" for others. Reuse the resolved function name for both imphash input and display string, avoiding divergence.	src/pe.rs
Introduce and wire up a pefile-derived ordinal lookup table for ws2_32/wsock32/oleaut32 with tests.	Add new ordinals module exposing special_ordinal_name(dll_lower, ordinal) with match-based tables for the three DLLs. Document that the tables are generated from pefile 2024.8.26 and must not be edited manually. Add unit tests validating expected lookups, case-sensitivity expectations, and non-special fallthrough behavior. Expose the ordinals module from main so it can be used by PE parsing code.	src/ordinals.rs src/main.rs
Release metadata update for the new imphash behavior.	Bump crate version from 0.1.2 to 0.1.3. Add a 0.1.3 changelog entry describing the imphash ordinal-resolution fix and the new ordinals table artifact. Update Cargo.lock to reflect the new version.	Cargo.toml CHANGELOG.md Cargo.lock

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}