[REMOTE-3146] Discover nested build cache roots - #15844
Merged
Merged
Conversation
Define bounded marker scanning, concurrent detection, stable nested cache paths, serial mount safety, and objective validation criteria.\n\nCo-Authored-By: Warp Agent <agent@warp.dev>
Contributor
Author
|
This PR was generated with Warp. Comment |
bnavetta
reviewed
Sep 8, 2026
bnavetta
approved these changes
Sep 8, 2026
bnavetta
reviewed
Sep 9, 2026
Drop the module-doc lines and function doc sentences that restated the producer's mechanics, keeping the invariants that the code does not state itself.
bnavetta
reviewed
Sep 9, 2026
Select one most-specific marker root, use only the walk resource bound, and improve discovery diagnostics, tracing, and stable ID generation. Keep the tests and technical specification aligned with the behavior.
Split the reviewer-prescribed helper documentation at its sentence boundary to comply with the repository's 100-column comment rule.
Describe the helper's file and directory marker contract through its most-specific match rule without implying that every entry is a file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Discovers nested build and package roots using detector-aligned markers, then pipelines root and nested
spacectldetections through one shared concurrency-8 pool. A Tokio blocking task owns the synchronousWalkDirtraversal and feeds a bounded capacity-8 channel, which removes resumable iterator state while preserving deterministic selection and backpressure. A whole-discovery child span is created under the active cache-setup span and entered on the blocking thread, with per-repository child spans preserving the trace hierarchy.Nested roots receive stable isolated cache paths; results return to canonical order before planning, all real mounts remain serial, and the global mount remains last. Traversal stays bounded to 10,000 directories and 32 child roots per repository, skips ignored and symlinked trees, and isolates per-root preparation or detection failures. Receiver drop stops the producer through failed
blocking_sendorSender::is_closed()checks.Linked Issue
ready-to-specorready-to-implement— the work item is in Linear, where this GitHub-specific label does not apply.Testing
./script/formatcargo clippy -p build_cache --all-targets --all-features --tests -- -D warningscargo nextest run --no-fail-fast -p build_cache— 48 passedcargo nextest run --no-fail-fast -p warp cache_setup— 3 passedcargo run -p build_cache --example validate_spacectl -- empty— reached complete validation without the prior missing-reactor panic; exited 1 because the sandbox detectedaptand destructive mounts degradedcargo check -p warp --libgit diff --checkspacectlis 0.12.2 (df91f93)app/src/ai/execution_profilesand dead-code failures.wasm32-unknown-unknown, and installing it is permission-blocked.cargo tree -p warp --target wasm32-unknown-unknown -i build_cacheconfirms the native-only crate is absent from the wasm graph; CI remains the compilation proof.spacectlbinary.Agent Mode
CHANGELOG-IMPROVEMENT: Discover and cache build tools in nested repository directories.