Clean up CloudModeImageContext feature flag - #15842
Conversation
|
@warp-for-oss[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the CloudModeImageContext Cargo/runtime feature flag and makes the previously gated cloud-mode attachment paths unconditional.
Concerns
app/src/ai/blocklist/controller/shared_session.rs:726changes an inline comment that still restates the immediately following branch instead of explaining non-obvious rationale, which conflicts with Warp's comment guidance.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| // If there are no file downloads (or the feature is disabled), send the query immediately. | ||
| if file_downloads.is_empty() || !FeatureFlag::CloudModeImageContext.is_enabled() { | ||
| // If there are no file downloads, send the query immediately. |
There was a problem hiding this comment.
file_downloads.is_empty() branch below; Warp's comment guidance reserves inline comments for non-obvious why. Remove it or replace it with the rationale for sending before the download path.
1 participant
Automated cleanup of the
CloudModeImageContextfeature flag.This PR was generated by the feature flag cleanup workflow.