Skip to content

Clean up CloudModeFromLocalSession feature flag #15834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warp-for-oss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up CloudModeFromLocalSession feature flag #15834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,6 @@ default = [
"bundled_skills",
"ambient_agents_rtc",
"cloud_mode",
"cloud_mode_from_local_session",
"cloud_mode_image_context",
"agent_mode_computer_use",
"background_computer_use",
Expand Down Expand Up @@ -975,7 +974,6 @@ named_agents = []
classic_completions = []
native_shell_completions = []
cloud_mode = []
cloud_mode_from_local_session = []
cloud_mode_image_context = []
force_classic_completions = []
agent_view_conversation_list_view = ["agent_view"]
Expand Down
2 changes: 0 additions & 2 deletions app/src/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ fn enabled_features() -> HashSet<FeatureFlag> {
FeatureFlag::InlineRepoMenu,
#[cfg(feature = "cloud_mode")]
FeatureFlag::CloudMode,
#[cfg(feature = "cloud_mode_from_local_session")]
FeatureFlag::CloudModeFromLocalSession,
#[cfg(feature = "cloud_mode_image_context")]
FeatureFlag::CloudModeImageContext,
#[cfg(feature = "summarization_via_message_replacement")]
Expand Down
2 changes: 1 addition & 1 deletion app/src/search/slash_command_menu/static_commands/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ fn all_commands_for_all_surfaces() -> Vec<StaticCommand> {
commands.push(INVOKE_SKILL.clone());
}

if FeatureFlag::CloudMode.is_enabled() && FeatureFlag::CloudModeFromLocalSession.is_enabled() {
if FeatureFlag::CloudMode.is_enabled() {
commands.push(CLOUD_AGENT.clone());
}

Expand Down
4 changes: 1 addition & 3 deletions app/src/terminal/view/ambient_agent/view_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,9 +735,7 @@ impl TerminalView {
initial_prompt: Option<String>,
ctx: &mut ViewContext<Self>,
) {
if !(FeatureFlag::CloudMode.is_enabled()
&& FeatureFlag::CloudModeFromLocalSession.is_enabled())
{
if !FeatureFlag::CloudMode.is_enabled() {
return;
}

Expand Down
6 changes: 1 addition & 5 deletions app/src/terminal/view/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,11 +1099,7 @@ pub fn init(app: &mut AppContext) {
TerminalAction::EnterCloudAgentView,
id!("Terminal") & id!(flags::IS_ANY_AI_ENABLED),
)
.with_enabled(|| {
FeatureFlag::AgentView.is_enabled()
&& FeatureFlag::CloudMode.is_enabled()
&& FeatureFlag::CloudModeFromLocalSession.is_enabled()
})
.with_enabled(|| FeatureFlag::AgentView.is_enabled() && FeatureFlag::CloudMode.is_enabled())
.with_group(bindings::BindingGroup::WarpAi.as_str())]);
if cfg!(target_os = "macos") {
// On MacOS, if the user has the 'Option as meta' setting enabled, the cmd-alt-enter
Expand Down
3 changes: 0 additions & 3 deletions crates/warp_features/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,9 +563,6 @@ pub enum FeatureFlag {
/// Enables cloud mode functionality for ambient agents.
CloudMode,

/// Enables starting cloud mode from a local session.
CloudModeFromLocalSession,

/// Enables host selection in cloud mode.
CloudModeHostSelector,

Expand Down
Loading