Fix macOS hang when opening Mermaid plans - #15830
Draft
warp-agent-staging[bot] wants to merge 2 commits into
Draft
Fix macOS hang when opening Mermaid plans#15830warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
Contributor
Author
There was a problem hiding this comment.
Overview
The code, regression coverage, and lifecycle contract findings are resolved. One acceptance-verification gap requires human judgment.
Concerns
- No recording or process sample proves the opted-in macOS tab-switch path. Both attempts were blocked by runner authentication rather than product behavior; verify with an authorized macOS user/test fixture and capture the switch plus a sample showing
Presenter::layoutno longer spends most of its time in RayonLockLatch::wait_and_reset.
Verdict
Checks: build pass, tests pass, CI draft-skipped, visual proof missing
Found: 0 critical, 1 important, 0 suggestions, 0 nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes APP-5824 by initializing rendered Mermaid offsets when a lazy plan editor binds to its window, before its first element layout. Lazy edit flushing on macOS now lays out sequentially, avoiding a main-thread wait on Rayon workers concurrently entering CoreText.
Linked Issue
Testing
MermaidDiagramat the command range; the pre-fix form fails onmaster. The sequential regression compares wrapped text, multiline code, hidden-block placement, and rendered frame/line geometry.cargo nextest run -p warp_editor(502 passed)cargo nextest run -p warp -E 'test(notebooks::editor::model::tests)'(72 passed)cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warnings./script/format --check,./script/check_no_inline_test_modules, andcargo check -p warp_editor -p warp --all-targets --testscargo build --bin warppassed at0005ccf7243e736d2b628fc780d269ed88b96043../script/run— a second interactive macOS retry prevented display sleep and launched Warp, but the injected credential is a service account (Unauthorized: Expected a user account), leaving the GUI in onboarding and the exact conversation redirected to login. The tab-switch and replacement process sample remain blocked; no unrelated proxy was substituted.Agent Mode
CHANGELOG-BUG-FIX: Fixed a hang when opening restored plans containing Mermaid diagrams on macOS.