fix: commit inline renames on vertical-tabs click-away - #15828
Draft
warp-for-oss[bot] wants to merge 1 commit into
Draft
fix: commit inline renames on vertical-tabs click-away#15828warp-for-oss[bot] wants to merge 1 commit into
warp-for-oss[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Ben Holmes <51384119+bholmesdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14240
Summary
CommitActiveRenameworkspace action for inline rename click-away behavior.CancelActiveRenamefor explicit cancel paths and cover tab/tab-group behavior with regression tests.Validation
./script/formatCARGO_HOME=/home/agent/.cargo CARGO_BUILD_JOBS=1 cargo check -p warp --libCARGO_HOME=/home/agent/.cargo CARGO_BUILD_JOBS=1 cargo nextest run -p warp -E 'test(active_rename)'— 4 passedCARGO_HOME=/home/agent/.cargo CARGO_BUILD_JOBS=1 cargo clippy -p warp --lib --tests -- -D warningsNotes
CARGO_HOME=/home/agent/.cargo CARGO_BUILD_JOBS=1 cargo clippy --workspace --all-targets --all-features --tests -- -D warnings. It failed on existing unrelateddead_codeerrors in terminal/local-tty files before reaching this diff as a clean full-workspace pass.