Skip to content

Route shared session navigation by Factory access - #15824

Open
warp-agent-staging[bot] wants to merge 2 commits into
masterfrom
factory/app-5796-shared-session-navigation
Open

Route shared session navigation by Factory access#15824
warp-agent-staging[bot] wants to merge 2 commits into
masterfrom
factory/app-5796-shared-session-navigation

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Routes the simplified WASM shared-session and conversation header back into Factory for Factory-enabled users while retaining legacy Oz navigation for other users. The authoritative Factory access probe controls both the Warp logo destination and the adjacent product action; loading and request failures remain on the legacy Oz fallback.

Linked Issue

https://linear.app/warpdotdev/issue/APP-5796/route-the-factory-app-warp-logo-back-to-the-platform

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • cargo nextest run -p warp -E 'test(factory_access_request) | test(factory_access_updates_workspace_navigation_asynchronously) | test(denied_factory_access_keeps_legacy_destination_and_refreshes_button) | test(failed_factory_access_preserves_loading_fallback) | test(simplified_wasm_navigation)' (7 passed)

  • ./script/format

  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings

  • cargo clippy -p warp --all-targets --tests -- -D warnings

  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings

  • ./script/wasm/bundle --check-only --channel dev

  • Built the local-channel browser bundle and verified Factory action, Warp-logo, denied-access fallback, and failed-probe fallback navigation

  • Independently decoded the four new H.264 MP4 recordings: 69, 69, 69, and 20 frames (1.33–4.60 seconds)

  • ./script/presubmit previously passed formatting, clippy, clang-format, Factory-file validation, and WGSL formatting; the full workspace test phase could not finish after the sandbox ran out of disk space while linking TUI test binaries.

  • I have manually tested my changes locally with the browser-built WASM app

Screenshots / Videos

Computer-use video recordings (9)

Navigating to the Warp shared-session URL, waiting for the WASM bundle to initialize, and observing that the header never renders due to a fatal 'env' module resolution error, then attempting to locate/click the product navigation action next to Open in Warp.
Warp shared-session header load attempt: Navigating to the Warp shared-session URL, waiting for the WASM bundle to initialize, and observing that the header never renders due to a fatal 'env' module resolution error, then attempting to locate/click the product navigation action next to Open in Warp.

Recording a fresh browser tab loading http://localhost:8080/session/00000000-0000-4000-8000-000000000001, observing the header once rendered, and clicking the secondary product navigation control next to Open in Warp.
Loading Warp shared-session page and testing header navigation: Recording a fresh browser tab loading http://localhost:8080/session/00000000-0000-4000-8000-000000000001, observing the header once rendered, and clicking the secondary product navigation control next to Open in Warp.

Recording the flow of completing the skip-login path on the Warp session welcome gate, observing the resulting simplified header with the Warp logo and "View in Oz"/"Open in Warp" actions, then clicking "View in Oz" and showing the resulting destination.
Skip login and click secondary product action in session header: Recording the flow of completing the skip-login path on the Warp session welcome gate, observing the resulting simplified header with the Warp logo and "View in Oz"/"Open in Warp" actions, then clicking "View in Oz" and showing the resulting destination.

Shows the authenticated representative session page header with Warp logo, View Factory, and Open in Warp actions, then clicking View Factory to navigate to the Factory destination.
Clicking View Factory beside Open in Warp on the Warp session page: Shows the authenticated representative session page header with Warp logo, View Factory, and Open in Warp actions, then clicking View Factory to navigate to the Factory destination.

Shows the authenticated shared-session header with View Factory and Open in Warp buttons, then clicks the Warp logo at top-left and shows the resulting destination.
Shared-session header and Warp logo navigation: Shows the authenticated shared-session header with View Factory and Open in Warp buttons, then clicks the Warp logo at top-left and shows the resulting destination.

Shows the fully loaded shared-session header, clicking the 'View Factory' text button beside the 'Open in Warp' desktop control, and the resulting navigation to the Factory destination page.
Clicking View Factory button in Warp shared-session header: Shows the fully loaded shared-session header, clicking the 'View Factory' text button beside the 'Open in Warp' desktop control, and the resulting navigation to the Factory destination page.

Shows the stable Factory-enabled shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, clicking the small Warp logo at the far left of the header, and the resulting navigation to the destination page.
Clicking far-left Warp logo on shared-session header: Shows the stable Factory-enabled shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, clicking the small Warp logo at the far left of the header, and the resulting navigation to the destination page.

Shows the authoritative Factory access response with allowed:false, then navigates to the shared-session page, shows View in Oz beside Open in Warp, clicks View in Oz, and reaches the legacy /runs destination.
Denied Factory access falls back to legacy Oz: Shows the authoritative allowed:false response, the resulting View in Oz action beside Open in Warp, and navigation to the legacy /runs destination.

Shows the stable failed-probe shared-session header, clicking the "View in Oz" fallback text button beside "Open in Warp", browser navigation, and the resulting legacy destination page with heading and requested path.
Warp shared-session fallback navigation to legacy Oz destination: Shows the stable failed-probe shared-session header, clicking the "View in Oz" fallback text button beside "Open in Warp", browser navigation, and the resulting legacy destination page with heading and requested path.

Computer-use screenshots (10)

Factory-access shared-session header showing Warp logo (top-left), "View Factory" and "Open in Warp" buttons (top-right, adjacent), a three-dot menu icon far right, and session body showing "Failed to connect. Please try again later." error plus "Loading session..." spinner text.
Factory-access shared-session header showing Warp logo (top-left), "View Factory" and "Open in Warp" buttons (top-right, adjacent), a three-dot menu icon far right, and session body showing "Failed to connect. Please try again later." error plus "Loading session..." spinner text.

Destination page reached after clicking "View Factory" - URL localhost:8080, title "Factory destination reached", showing heading "Factory destination reached" and text "Configured server root: http://localhost:8080".
Destination page reached after clicking "View Factory" - URL localhost:8080, title "Factory destination reached", showing heading "Factory destination reached" and text "Configured server root: http://localhost:8080".

Fully loaded Warp WASM shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, showing the logo icon (top-left), "View Factory" and "Open in Warp" buttons, and a three-dot menu (top-right), with a "Failed to join shared session" error banner and "Loading session..." spinner in the body.
Fully loaded Warp WASM shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, showing the logo icon (top-left), "View Factory" and "Open in Warp" buttons, and a three-dot menu (top-right), with a "Failed to join shared session" error banner and "Loading session..." spinner in the body.

Destination page after clicking "View Factory": URL is localhost:8080, heading "Factory destination reached", body text "Configured server root: http://localhost:8080".
Destination page after clicking "View Factory": URL is localhost:8080, heading "Factory destination reached", body text "Configured server root: http://localhost:8080".

Fully loaded Warp shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, showing the small Warp logo at far left, "View Factory" and "Open in Warp" buttons at far right, a three-dot menu icon at the very edge, and a "Failed to join shared session" error banner with "Loading session..." spinner in the body.
Fully loaded Warp shared-session header at localhost:8080/session/00000000-0000-4000-8000-000000000001, showing the small Warp logo at far left, "View Factory" and "Open in Warp" buttons at far right, a three-dot menu icon at the very edge, and a "Failed to join shared session" error banner with "Loading session..." spinner in the body.

Destination page after clicking the far-left Warp logo: URL is localhost:8080, showing heading "Factory destination reached" and body text "Configured server root: http://localhost:8080".
Destination page after clicking the far-left Warp logo: URL is localhost:8080, showing heading "Factory destination reached" and body text "Configured server root: http://localhost:8080".

Stable shared-session page showing "Failed to join shared session" error, with header controls: left icon logo, and right-aligned "View in Oz" text button, "Open in Warp" button, and a three-dot menu, at URL localhost:8080/session/00000000-0000-4000-8000-000000000001
Stable shared-session page showing "Failed to join shared session" error, with header controls: left icon logo, and right-aligned "View in Oz" text button, "Open in Warp" button, and a three-dot menu, at URL localhost:8080/session/00000000-0000-4000-8000-000000000001

Destination page after clicking "View in Oz": URL localhost:8082/runs, heading "Legacy Oz destination reached", body text "Requested path: /runs"
Destination page after clicking "View in Oz": URL localhost:8082/runs, heading "Legacy Oz destination reached", body text "Requested path: /runs"

Stable failed-probe shared-session header showing "Failed to join shared session." error, with fallback navigation controls "View in Oz" and "Open in Warp" visible in the top-right header at localhost:8080/session/00000000-0000-4000-8000-000000000001.
Stable failed-probe shared-session header showing "Failed to join shared session." error, with fallback navigation controls "View in Oz" and "Open in Warp" visible in the top-right header at localhost:8080/session/00000000-0000-4000-8000-000000000001.

Resulting destination page after clicking "View in Oz": URL localhost:8082/runs showing heading "Legacy Oz destination reached" and body text "Requested path: /runs".
Resulting destination page after clicking "View in Oz": URL localhost:8082/runs showing heading "Legacy Oz destination reached" and body text "Requested path: /runs".

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Shared session pages now link back to Factory for Factory-enabled users.

@cla-bot cla-bot Bot added the cla-signed label Sep 4, 2026
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review September 5, 2026 01:53
@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants