REMOTE-2111: promote PeriodicHandoffCheckpoints to PREVIEW_FLAGS - #15820
REMOTE-2111: promote PeriodicHandoffCheckpoints to PREVIEW_FLAGS#15820joeywangzr wants to merge 1 commit into
Conversation
Second stage of the staged rollout for the periodic workspace-handoff checkpoint coordinator. Moves FeatureFlag::PeriodicHandoffCheckpoints from DOGFOOD_FLAGS to PREVIEW_FLAGS so the coordinator is exercised on preview/canary builds (which also covers dogfood, since PREVIEW_FLAGS is automatically included there) ahead of a stable rollout via RELEASE_FLAGS. Co-Authored-By: Warp <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR promotes FeatureFlag::PeriodicHandoffCheckpoints from dogfood-only to preview by removing it from DOGFOOD_FLAGS, adding it to PREVIEW_FLAGS, and updating the flag documentation to describe the new rollout state. The existing dev/dogfood channel setup also includes PREVIEW_FLAGS, so dogfood coverage is preserved.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
What this does
Second stage of the staged rollout for the periodic workspace-handoff checkpoint coordinator (previously enabled for dogfood only in #15026, after #14589, #14573, #14588). Moves
FeatureFlag::PeriodicHandoffCheckpointsfromDOGFOOD_FLAGStoPREVIEW_FLAGSso the coordinator bakes on preview/canary builds before promoting toRELEASE_FLAGS(or enabling it by default) for stable.Dogfood coverage is preserved:
PREVIEW_FLAGSis automatically included in dogfood builds, so removing the flag fromDOGFOOD_FLAGSis a no-op for dogfood.OzHandoff(the other prerequisite flag) remains enabled by default for all builds via theoz_handoffCargo default feature, so no additional change is needed there.Linked Issue
Testing
cargo check -p warp_features,cargo clippy -p warp_features --all-targets --all-features -- -D warnings,cargo test -p warp_features, andcargo fmt --check -p warp_featuresall pass.CHANGELOG-NONE
Co-Authored-By: Warp agent@warp.dev