[APP-5777] Resolve loadSpec lazily during completion traversal - #15817
Open
warp-agent-staging[bot] wants to merge 9 commits into
Open
[APP-5777] Resolve loadSpec lazily during completion traversal#15817warp-agent-staging[bot] wants to merge 9 commits into
warp-agent-staging[bot] wants to merge 9 commits into
Conversation
Pin warp-command-signatures to the unresolved-loadSpec commit and overlay wrapper/target members by borrowing cached signature trees instead of cloning composed results.
Contributor
Author
|
This PR was generated with Warp. Comment    |
Store every resolved target on the borrowed view instead of dropping links after four, and look up generators/filters in the DynamicCompletionData that owns the wrapper or target option.
When traversal enters a subcommand from a loadSpec target, keep that target's DynamicCompletionData so generators and filters on the child resolve from the target, not the original wrapper.
acarl005
marked this pull request as ready for review
September 4, 2026 19:49
wrapper/wrapper_dcd become current/current_dcd after loadSpec descent. Pin warp-command-signatures to the corpus that drops dangling aws/gcloud loadSpec pointers.
Bump warp-command-signatures to 1e9de7e so slash-path loadSpec targets from command-signatures#390 resolve during lazy traversal. Co-Authored-By: Warp Agent <agent@warp.dev>
Bump warp-command-signatures to d25f45a so the nested Fig import queue follows slash-path loadSpec refs discovered inside imported targets. Co-Authored-By: Warp Agent <agent@warp.dev>
Bump warp-command-signatures to 2946535 so nested aws/gcloud specs are embedded via rust-embed's native include-flate compression. Co-Authored-By: Warp Agent <agent@warp.dev>
Bump warp-command-signatures to 2d83dc5 so aws/gcloud loadSpec targets are imported as runtime-only sanitized JSON under autogenerated/load_spec_targets. Co-Authored-By: Warp Agent <agent@warp.dev>
…loud. Bump warp-command-signatures to f465881 after dropping the dedicated autogenerated subtree. Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve static
loadSpecreferences lazily in the legacy completer instead of composing trees at load time. Coordinated with command-signatures#390. Tracking: APP-5777.Pinned to command-signatures
f465881. Referenced AWS/GCloud targets are sanitized runtime-only JSON at their naturaljson/awsandjson/gcloudpaths (35.89 MiB raw, item-local descriptions capped at 240 characters), looked up asaws/<name>/gcloud/<name>, with native rust-embed compression.Linked Issue
ready-to-specorready-to-implement.Testing
Added
warp_completerregistry tests for lookup-before-entry,fvm flutter, slash-path targets, five-link nested references, missing targets, cycles, wrapper overlay, persistent options, per-origin generator/filter data, loaded-target descendants, and alias expansion.cargo nextest run -p warp_completer --lib -E 'test(registry) or test(load_spec)': 31 passed against pinf465881.command-signatures library tests: 180 passed, including strict all-assets graph validation, natural slash-path lookup, suggestion preservation, unsupported-data removal, and description bounds.
Full GUI build passed at exact head
9ddcd40b:WARP_SKIP_COMMON_SKILLS_INSTALL=1 cargo build --bin warp-oss --features "gui,fast_dev".Fresh-process computer-controlled verification on the exact head confirmed:
aws application-autoscalingexposes imported service subcommands.delete-scaling-policy --resource-idshows the concise item-specific description “The identifier of the resource associated with the scalable target.”gcloud computeexposes imported Compute targets and descriptions.Video: AWS and GCloud natural-path lazy targets
Screenshot: concise AWS
--resource-iddescriptionScreenshot: GCloud Compute target completions
All current command-signatures and Warp CI checks are green, including Linux/macOS/Windows tests, formatting/Clippy, release-feature builds, and CodeQL.
I have manually tested my changes locally with
./script/runor the equivalent built binary.Agent Mode
CHANGELOG-NONE