[APP-5810] Share precise deltas across EditDelta clones - #15810
Open
warp-agent-staging[bot] wants to merge 1 commit into
Open
[APP-5810] Share precise deltas across EditDelta clones#15810warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Store EditDelta precise deltas behind Arc so delayed-rendering clones retain one allocation while preserving existing read-only behavior. ticket_source=linear ticket_id=APP-5810 Co-Authored-By: Warp Agent <agent@warp.dev>
warp-agent-staging
Bot
added
the
area:performance:memory
Contributor
Author
|
This PR was generated with Warp. Comment   |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EditDelta::precise_deltasnow usesArc<Vec<PreciseDelta>>, so clones retained by delayed rendering share the same allocation instead of copying every precise delta. All consumers remain read-only, and existing undo/redo behavior is preserved.ticket_source=linear ticket_id=APP-5810Linked Issue
APP-5810 contains the supporting memory-profile evidence.
ready-to-specorready-to-implement. Not applicable; the linked work item is a Linear issue in progress.Testing
./script/format --check— passedcargo check --manifest-path /workspace/warp-app-5810/Cargo.toml -p warp --lib— passedcargo nextest run --manifest-path /workspace/warp-app-5810/Cargo.toml -p warp_editor— 502 passedcargo nextest run --manifest-path /workspace/warp-app-5810/Cargo.toml -p warp_editor -E 'test(edit_delta_clone_shares_precise_delta_allocation)'— 1 passedcargo clippy --manifest-path /workspace/warp-app-5810/Cargo.toml --workspace --exclude warp_completer --all-targets --tests -- -D warnings— passedcargo clippy --manifest-path /workspace/warp-app-5810/Cargo.toml -p warp --all-targets --tests -- -D warnings— passedcargo clippy --manifest-path /workspace/warp-app-5810/Cargo.toml -p warp_completer --all-targets --tests -- -D warnings— passedI have manually tested my changes locally with
./script/run. Not applicable; the behavior is covered by unit tests and compile/lint checks.Agent Mode
CHANGELOG-NONE