Surface more descriptive errors for local-to-cloud handoff failures#11012
Merged
harryalbert merged 1 commit intoMay 15, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
harryalbert
force-pushed
the
harry/app-4496-make-error-toasts-more-descriptive-for-handoff
branch
2 times, most recently
from
efb917c to
671435a
Compare
harryalbert
changed the title
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR replaces the generic local-to-cloud handoff failure toast with branch-specific messages and adds more contextual warnings.
Concerns
- The new cloud pane failure warning logs
forked_conversation_id, which is later persisted as the server conversation token for the local fork. That token should not be written to client logs.
Security
- Omit or redact
forked_conversation_idfrom the new warning so conversation tokens do not end up in logs.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
captainsafia
approved these changes
May 15, 2026
harryalbert
force-pushed
the
harry/app-4496-make-error-toasts-more-descriptive-for-handoff
branch
from
671435a to
d7b3aa3
Compare
harryalbert
deleted the
harry/app-4496-make-error-toasts-more-descriptive-for-handoff
branch
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
…arpdotdev#11012) ## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> We were using one generic error toast message for a bunch of different local -> cloud handoff modes (and weren't logging descriptive warnings/errors in all cases). This made debugging harder , and also made it harder for folks to understand why local -> cloud handoff was failing in some cases. To fix this, we should make all of the error toasts clear and descriptive, and add helpful logging for debugging in all cases. ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were using one generic error toast message for a bunch of different local -> cloud handoff modes (and weren't logging descriptive warnings/errors in all cases). This made debugging harder , and also made it harder for folks to understand why local -> cloud handoff was failing in some cases.
To fix this, we should make all of the error toasts clear and descriptive, and add helpful logging for debugging in all cases.
Testing
./script/runAgent Mode