Fix ambient agent loading screen persisting after session starts#10994
Draft
warp-dev-github-integration[bot] wants to merge 2 commits into
Draft
Fix ambient agent loading screen persisting after session starts#10994warp-dev-github-integration[bot] wants to merge 2 commits into
warp-dev-github-integration[bot] wants to merge 2 commits into
Conversation
Add ctx.notify() back to the SessionReady/FollowupSessionReady handler. Without this call, the view never re-renders after the model status changes to AgentRunning, so the loading overlay from the previous render cycle stays visible even though agent_progress() now returns None. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where the ambient agent loading screen persists after the agent session has started.
The
SessionReady/FollowupSessionReadyevent handler was missing actx.notify()call. Without it, theTerminalViewnever re-renders after the model status transitions fromWaitingForSessiontoAgentRunning. This means the loading overlay (or status bar progress indicator) from the previous render cycle stays on screen even thoughagent_progress()now returnsNone.Every other event handler in this component that needs a visual update calls both
ctx.emit(TerminalViewEvent::TerminalViewStateChanged)(to notify the parent) andctx.notify()(to trigger this view's re-render). TheSessionReadyhandler was the only one missing the latter.Linked Issue
ready-to-specorready-to-implement.Testing
./script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/7d5a0d35-7c13-4c5b-aea3-48e07ce79f56
Run: https://oz.staging.warp.dev/runs/019e2a9f-76b5-7c36-9fbe-f2975bc782b5
This PR was generated with Oz.