Add backend.docker.sidecar_image config override - #133
Merged
Conversation
Allow operators to set backend.docker.sidecar_image so managed Docker workers can pull the warp-agent /agent sidecar from a private registry mirror, matching the existing Kubernetes override. REMOTE-3065
Contributor
Author
|
This PR was generated with Warp. Comment    |
Private-registry mirrors of warp-agent require the same registry auth as the task image. Additional sidecars stay unauthenticated. REMOTE-3065
Sidecar images stay public and are pulled without registry credentials. backend.docker.sidecar_image still overrides the /agent image name. REMOTE-3065
captainsafia
approved these changes
Aug 28, 2026
|
An unexpected error has occurred: managed MCP server 01a01a21-3ec9-71a1-99f2-f13b1773c920 is not active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker always used the server-provided warp-agent sidecar image. This adds
backend.docker.sidecar_imagewith the same rules as Kubernetes: override only when the assignment includes a sidecar image, and do not rewrite additional sidecars. Sidecar pulls stay anonymous.What changed
backend.docker.sidecar_image(optional, no whitespace).mergeConfigintoDockerBackendConfig.prepareTaskParamsbefore sidecar prep, sharing a helper with the Kubernetes override.Helm is unchanged. The chart always deploys the Kubernetes backend.
Fixes https://linear.app/warpdotdev/issue/REMOTE-3065/oz-agent-worker-add-backenddockersidecar-image-config-override
Validation
go test ./... -count=1,go vet ./..., andgofmt -s -l .all passed locally. Tests cover YAML load, merge into worker config, Docker and Kubernetes override/empty/nil cases, and that additional sidecars are left alone.