fix(docs): make Agent docs review the only gate - #688
Conversation
Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR changes the agent-docs review publisher to submit non-blocking review comments and adds a workflow step/script to dismiss stale automated change-request reviews.
Concerns
- The stale-review dismissal step only reads the first page of pull request reviews, so a long-lived PR can keep an older bot change-request review on a later page and still be blocked by GitHub review state.
- The dismissal pipeline can mask failures from the Python selector under the workflow's default shell behavior, leaving stale review states in place while later steps continue.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| gh api "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100" > /tmp/reviews.json |
There was a problem hiding this comment.
CHANGES_REQUESTED review on a later page and still keep GitHub's review gate blocking merge after this step completes. Paginate and slurp all pages before passing them to stale_review_requests.py.
| python3 .agents/skills/doc_quality_policy/stale_review_requests.py \ | ||
| --reviews /tmp/reviews.json \ | ||
| --head-sha "${{ github.event.pull_request.head.sha }}" | | ||
| while IFS= read -r review_id; do |
There was a problem hiding this comment.
stale_review_requests.py exits non-zero, this pipeline can still succeed under the default implicit bash shell because only the while loop's status is checked; that would skip dismissals without failing the workflow. Enable pipefail or write the selected IDs to a temp file before looping.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
Summary
Makes the required Agent docs review status check the only automated merge gate. Bot review results remain visible on the PR, but they no longer create a sticky GitHub
CHANGES_REQUESTEDstate.Changes
CHANGES_REQUESTEDreviews created bygithub-actions[bot]; human reviews and the current commit's review remain untouched.Unverified claims
None — this changes internal documentation-review automation only.
Documentation risk
Risk: low
Rationale: This internal review-workflow change removes stale bot review states without changing public product documentation.
Docs override: none
Validation
python3 .agents/skills/doc_quality_policy/test_publish_review_signal.py— passed (4 tests).python3 .agents/skills/doc_quality_policy/test_verify_review_signal.py— passed (14 tests).python3 .agents/skills/doc_quality_policy/test_stale_review_requests.py— passed.Co-Authored-By: Warp agent@warp.dev