Skip to content

fix(docs): hide automated review signals #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachaelrenk merged 1 commit into from
Sep 4, 2026
+8 −2
Merged

fix(docs): hide automated review signals #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .agents/skills/doc_quality_policy/publish_review_signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ def build_review_payload(
"The independent agent completed its review for this commit.\n\n"
f"## Findings\n{findings}\n\n"
f"## Verdict\n{signal['verdict']}\n\n"
"## Review signal\n"
f"[SIGNAL:pr-review] {json.dumps(signal, sort_keys=True)}"
f"<!-- [SIGNAL:pr-review] {json.dumps(signal, sort_keys=True)} -->"
),
}

Expand Down
7 changes: 7 additions & 0 deletions .agents/skills/doc_quality_policy/test_publish_review_signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ def test_approve_maps_to_github_approval(self):
self.assertEqual(payload["event"], "APPROVE")
self.assertEqual(payload["commit_id"], "sha1")
self.assertIn("## Verdict\nApprove", payload["body"])
self.assertNotIn("## Review signal", payload["body"])
self.assertIn("<!-- [SIGNAL:pr-review]", payload["body"])
self.assertIn('"reviewer_login": "github-actions[bot]"', payload["body"])
published_signal, problems = prs.vrs._parse_signal(
payload["body"], "1", "sha1"
)
self.assertEqual(problems, [])
self.assertEqual(published_signal["reviewer_login"], "github-actions[bot]")

def test_approve_with_nits_maps_to_github_approval(self):
payload = prs.build_review_payload(
Expand Down
Loading