Port Fig generators to Rust

[warp-agent-staging]

Summary

Port ignored Fig generators to supported generatorName wiring (APP-5776). Identical command+script generators share one name and one CommandSignatureGenerators value. Original generateSpec JSON is restored from main and left unimplemented.

Changes

• Collapse duplicate Fig script generators; Amplify env_list is one registration
• Semantic names only—no numeric suffixes, no fig_<hash>
• One registry entry per command; no DynamicCompletionData::extend
• Restore original generateSpec fields on 13 specs (15 occurrences)
• Drop the unit tests this PR had added

Verification

• cargo test: 176 + 10 passed
• cargo fmt --check, cargo clippy ... -D warnings, npm run format:check: passed

Out of scope

Structured postProcess parsers, token-aware custom generators, and template filters land on the stacked PR above this one.

[warp-agent-staging]

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

  

[acarl005]

@warp-factory /review

[warp-factories]

Merged by @acarl005 — closing out. The factory's last posted verdict was changes-requested on 890bd8ba; the merged revision 9f81e912 was a rebase of that same work onto current main, so the findings carried over unreviewed.

One item to carry forward: fig_parse::lines splits raw output on newlines, so the branches/log/status generators emit decorated text (* my-branch, abc1234 subject) as literal completion values. These names are consumed by hub.json, watson.json, and tailscale.json, so it is user-visible. The description scopes structured parsers to the stacked follow-up PR — worth covering there.

Responding as Warp for OSS: Open session · View run

[warp-factories]

Overview

This replaces the ignored Fig JavaScript generators/generateSpec fields with Rust-backed generatorName registrations, removing all 963 such JSON keys. Requesting changes: the shared parser converts structured command output into invalid completion values, and the new generators ship without the verification evidence this repository requires.

Concerns

• fig_parse::lines emits one suggestion per trimmed line, but it is wired to 137 registrations whose removed postProcess functions extracted arguments from JSON or structured text. amplify env list --json, ansible-doc --list --json, and cargo read-manifest will now offer raw JSON fragments as completion values. Parse per output format and add representative output fixtures for each migrated contract.
• The same parser is applied to git log --oneline, git status --short, and git branch, all of which emit decorated lines rather than bare values, so the inserted text is not a valid ref or path. These need the format-aware handling noted inline.
• No completion-dropdown evidence accompanies 137 new registrations across 90 generator modules. Repository guidance requires a real Warp screenshot showing generated entries for every new or modified generator; please add that before merge.
• Review coverage: correctness carries the blocking findings above; standards could not be verified locally because no Rust toolchain is available in this environment, though CI is green; complexity and comments were examined with no material concern; naming has the inline nit; tests do not cover the newly introduced parsers; security was examined with no applicable finding.

Verdict

Checks: build unverified (cargo unavailable), tests unverified (cargo unavailable), CI green (8/8), visual proof missing

Found: 0 critical, 3 important, 0 suggestions, 1 nit

Recommendation: request changes

Responding as Warp for OSS: Open session · View run

[warp-factories]

⚠️ [IMPORTANT] This line parser is wired to 137 new registrations, but many of the postProcess functions it replaces extracted arguments out of JSON or structured output. amplify env list --json, ansible-doc --list --json, and cargo read-manifest will now surface raw JSON fragments instead of completion values. Parse per output format and add representative output fixtures for each migrated contract.

[warp-factories]

⚠️ [IMPORTANT] git branch marks the checked-out branch with a leading * , so this parser suggests * my-branch rather than the valid ref my-branch. This module already has post_process_branches (git.rs:468), which strips the marker and preserves current-branch semantics — reuse it here. The log, status, and tag generators added just below have the same problem: --oneline, --short, and decorated tag output are not bare values.

[warp-factories]

🧹 [NIT] unknow_dev_null_possible neither describes the values being completed nor spells unknown correctly, which makes the JSON-to-Rust wiring hard to audit. Rename these script-derived identifiers to semantic names such as paging_values, decorations_values, color_values, and wrap_values.

Superseded by a new review pass at 890bd8b

[warp-factories]

Overview

This revision ports the ignored Fig generators fields to Rust generatorName registrations, collapses duplicate script generators, and restores the original generateSpec JSON (15 keys across 13 specs) as unimplemented. Requesting changes: the shared line parser still hands decorated and structured command output to the completion menu as literal values.

Concerns

• fig_parse::lines splits raw output on newlines and is the parser for all 137 migrated registrations, including ones whose removed postProcess extracted values out of JSON. amplify env list --json, ansible-doc --list --json, and cargo read-manifest will offer JSON fragments where environment, plugin, and binary names belong. See the inline findings for representative paths.
• On the stacked-PR split: the description places structured postProcess parsers on a follow-up PR, which is a reasonable way to divide the work, but the regression ships with this change. Once this merges, those 137 call sites execute and return unusable values until the follow-up lands. Either hold the affected registrations until their parsers exist, or land the two together.
• This revision drops the unit tests the PR had added, and the remaining registry test only asserts that a generator name resolves — it never exercises parser output. Add table-driven fixtures per output contract, covering git branch, git log --oneline, git status --short, and malformed JSON.
• The PR body contains no images. Repository guidance requires a real Warp completion dropdown showing generator-produced candidates for every new or modified generator; please add that evidence before merge.
• Review coverage: correctness carries the blocking findings above; standards are unverified locally because no Rust toolchain is available in this environment, though CI is green; complexity and comments were examined with no material concern; naming has the inline nit; security was examined with no applicable finding, as there are no dependency or CI changes and the restored JSON fields are inert.

Verdict

Checks: build unverified (cargo unavailable), tests unverified (cargo unavailable), CI green (8/8), visual proof missing

Found: 0 critical, 4 important, 0 suggestions, 1 nit

Recommendation: request changes

Responding as Warp for OSS: Open session · View run

[warp-factories]

⚠️ [IMPORTANT] This raw line splitter is the parser for 137 new registrations, though many of the postProcess functions it replaces extracted command arguments out of JSON or structured output. amplify env list --json, ansible-doc --list --json, and cargo read-manifest will now offer JSON fragments instead of environment, plugin, or binary names. Use a parser per output contract and add representative fixtures for each.

[warp-factories]

⚠️ [IMPORTANT] git branch prints the checked-out branch as * <branch>, so this parser suggests an invalid ref; branches_no, log --oneline, and status --short just below likewise expose decorated records verbatim. This module already has post_process_branches (git.rs:468) for the branch case — reuse it for both branch generators, and add parsers that extract the commit hash and the status path before suggesting them.

[warp-factories]

🧹 [NIT] unknow_dev_null_possible neither describes the values being completed nor spells unknown correctly, which makes the JSON-to-Rust wiring hard to audit. Rename these script-derived identifiers to semantic names such as paging_values, decorations_values, color_values, and wrap_values.

Fixed in a stack