Restore command-signatures PR ownership - #389
Conversation
Co-Authored-By: Warp <agent@warp.dev>
|
Re-reviewed at Resolved: the internal-source citation in No maintainer review requested — that gate opens only once the factory's review is approving. Responding as Warp for OSS: Open session · View run |
Co-Authored-By: Warp <agent@warp.dev>
There was a problem hiding this comment.
Overview
This PR reduces .github/STAKEHOLDERS to a single repository-wide owner (@acarl005) and vendors a 215-line App-team ownership catalogue at .agents/ownership-areas/app.md. Requesting changes: the catalogue publishes internal contact and unreleased-area detail in a public repository, and nothing here consumes it yet.
Concerns
- [important] [security]
.agents/ownership-areas/app.mdputs ~20 employee work email addresses and descriptions of unreleased/experimental areas into a public repository, when routing only needs a GitHub handle. Anything committed here is permanently public and scrapable. Drop the catalogue from this PR; if semantic routing is wanted later, land a repository-scoped, public-safe format that carries handles only. - [important] Semantic routing cannot take effect from this change alone. Only
.github/STAKEHOLDERSis parsed today (by the factory's owner-resolution script); no code in this repo or the deployed factory reads.agents/ownership-areas/, and the stated prerequisitewarpdotdev/warp-factories-for-oss#3is still open. Land the catalogue with its consumer, or narrow this PR to the single-owner fallback the description can honestly claim.
The * @acarl005 fallback itself is correct: the parser treats * as matching every path and takes the last matching rule, and acarl005 has write access here, so the routing works as intended once merged.
Verdict
Checks: build pass (CI), tests pass (CI test), CI green at read time (format, lint, test, CodeQL analyze pass; two CodeQL jobs pending), visual proof n/a
Found: 0 critical, 2 important, 1 suggestion, 0 nits
Recommendation: changes requested.
Responding as Warp for OSS: Open session · View run
Co-Authored-By: Warp <agent@warp.dev>
Superseded by a new review pass
There was a problem hiding this comment.
Overview
The routing change is now clean: .github/STAKEHOLDERS carries a self-contained comment above * @acarl005, and the vendored catalogue's contents are gone. Still requesting changes — the removed content stays publicly reachable in this branch's history, so this history should not be merged.
Concerns
- [important] [security] Commit
80a515a1is still an ancestor of the head and remains publicly reachable through this PR, so emptying the file later does not retract the employee work addresses or unreleased-area detail it published. Merging this branch carries that commit intomain's history. Replace it with a clean branch cut frommainthat contains only theSTAKEHOLDERSchange, and treat the data as already disclosed under the project's normal privacy process — a force-push cannot recall existing clones or cached objects. - [suggestion]
.agents/ownership-areas/app.mdis still added, now as a zero-byte file. It has no effect and no documented placeholder contract, and a future catalogue reader could not tell "present but empty" from "absent". Drop the path withgit rm .agents/ownership-areas/app.mdon the replacement branch.
Resolved since the last pass: the internal warp-ownership citation in .github/STAKEHOLDERS is now self-contained, the unconsumed catalogue is gone, and the title and description now describe what the change actually does.
Verdict
Checks: build pass, tests pass, CI green (all 8 checks passing), visual proof n/a
Found: 0 critical, 1 important, 1 suggestion, 0 nits
Recommendation: changes requested. The fix is a fresh branch, not another commit on this one.
Responding as Warp for OSS: Open session · View run
acarl005
left a comment
There was a problem hiding this comment.
nit: The .agents/ownership-areas/app.md is empty now but it's still there. You should delete it rather than leaving a blank file. It could potentially confuse someone (or an agent).
Description
Remove the temporary Safia/Varoon test routing from command-signatures and restore
@acarl005as the repository-wide path owner for pull requests.Semantic issue routing is intentionally not duplicated here. The Warp factory reads the live
warpdotdev/warp-ownershipsource through warpdotdev/warp-factories-for-oss#3.Testing
git diff --checkacarl005is a valid GitHub userAgent Mode
Conversation: https://staging.warp.dev/conversation/67c6ccfe-e995-4280-87f9-108832980402
Co-Authored-By: Warp agent@warp.dev