Repository navigation
fix: export the nats seed file as an absolute path in integration tests - #59
Merged
Merged
Conversation
muhammad-tahir-nawaz
had a problem deploying
to
development
October 14, 2026 12:55 — with
GitHub Actions
Error
sidrarasool
approved these changes
Oct 14, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly preserves seed creation while making it accessible from alternate working directories.
0 open findings
What changed in this PR
Exports the generated NATS seed file using an absolute path so integration tests work from nested service directories.
Changes:
- Documents why an absolute path is required.
- Writes the absolute seed path to
GITHUB_ENV.
| File | Description |
|---|---|
.github/workflows/integration-tests.yaml |
Exports the root-level NATS seed file with an absolute path. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed step writes
nats-nkey.seedat the job root but exportsNATS_NKEY_SEED_FILE=./nats-nkey.seed. The server and the test runner script run ininputs.working_directory, so for a monorepo service (e.g. asset-pipelineservices/asset-normalizer) the relative path points at a file that does not exist:failed to load NKey seed from ./nats-nkey.seed.What
Export
$PWD/nats-nkey.seed. The file stays where it was, so callers using the default working directory get the same file, and existing overrides (../../nats-nkey.seedin asset-pipeline,./nats-nkey.seedin pulse, blank in fleet-manager/worker-systems) are unaffected.