Skip to content

Remove pdf-mustache render suite and svg-mustache render suite.#49

Open
msporny wants to merge 1 commit into
mainfrom
deprecate-svg-pdf
Open

Remove pdf-mustache render suite and svg-mustache render suite.#49
msporny wants to merge 1 commit into
mainfrom
deprecate-svg-pdf

Conversation

@msporny
Copy link
Copy Markdown
Member

@msporny msporny commented Mar 25, 2026

This PR deprecates the svg-mustache and pdf-mustache render suites because the html render suite handles both use cases now.


Preview | Diff

@msporny
Copy link
Copy Markdown
Member Author

msporny commented Mar 25, 2026

Re-enable svg-mustache as a approach but mark it as "needing implementer feedback". Remove pdf-mustache support (as it's covered w/ HTML approach).

@TallTed TallTed changed the title Deprecate the svg-mustache and pdf-mustache render suites. Deprecate pdf-mustache render suite. Mark svg-mustache render suite as needing implementer feedback. Mar 25, 2026
@msporny msporny changed the title Deprecate pdf-mustache render suite. Mark svg-mustache render suite as needing implementer feedback. Remove pdf-mustache render suite and svg-mustache render suite. May 5, 2026
@msporny
Copy link
Copy Markdown
Member Author

msporny commented May 5, 2026

Discussion on the call today resulted in the following outcome: Split the PR into two separate PRs:

  1. Remove svg-mustache.
  2. Remove pdf-mustache.

Both are replaced by HTML render method.

@BigBlueHat
Copy link
Copy Markdown
Member

BigBlueHat commented May 19, 2026

There is a baseline example of a "sandboxed HTML" render method using Mustache as the template language on VC Examples now:
https://github.com/credential-handler/vc-examples/tree/main/credentials/html-render-method-mustache

That example can be found in the list of examples in the VC Viewer: https://digitalbazaar.github.io/vc-viewer/

I'm actively working on a PDF variation, but ran into the issues expressed in #53, so more information/guidance there would be appreciated.

/cc @dmitrizagidulin

@iherman
Copy link
Copy Markdown
Member

iherman commented May 20, 2026

This was discussed during the vcwg meeting on 19 May 2026.

View the transcript

Remove pdf-mustache render suite and svg-mustache render suite. by msporny · Pull Request #49 · w3c/vc-render-method · GitHub

Manu_Sporny: Okay, Benjamin, was that a we can't merge it yet until we discuss the other issue. too. Okay.

Benjamin_Young: I'm fine to take it out as I don't think we're losing anything per se. you had wanted to keep it in originally because it had the word PDF in it because SVG mustache and PDF mustache do exactly the same thing other than the media type. I'm fine to take them out.

Manu_Sporny: I think Dimmitri, it was you that wanted to keep the PDF mustache rendering template in if I recall correctly. Manu Sporny:

Dmitri_Zagidulin: No, no.

Dmitri_Zagidulin: Other way,…

Manu_Sporny: Okay.

<Dmitri_Zagidulin> (apologies, big calendar fail)

Dmitri_Zagidulin: other way around. I'd love to keep the SVG for the moment until I can figure out how to do the equivalent with the, I frame sandbox, plus one to removing PDF mustache.

Manu_Sporny: Got So, if we discuss your issue, Benjamin, do you think we could get closure on the PDF part of that?

Benjamin_Young: Yeah, I think so.

Benjamin_Young: Again, I don't remember any Sure. Manu Sporny:

Manu_Sporny: Sorry, the SVG part of it. Thank okay.

Benjamin_Young: Yeah, I think either way, it's going to help folks to know what the HTML render suite can and can't do currently. but I think we also need to be aligned on expectations of what we're expecting the render method to be capable of Manu Sporny:

Manu_Sporny: So Dimmitri, if we were able to demonstrate that the HTML render suite can do what the SVG one does today,…

Manu_Sporny: equivalent can pop out a SVG, then you would be okay with removing both of them. All right.

Dmitri_Zagidulin: Yeah. Yes.

Dmitri_Zagidulin: Yes. But…

Manu_Sporny: All right.

Dmitri_Zagidulin: but in the interest of progress,…

Manu_Sporny: So yeah.

Dmitri_Zagidulin: we can just split it into two, right? Remove the PDF mouth stash now and remove the SVG shortly.

Manu_Sporny: Yeah. The only thing I'm concerned about is I've been meaning to get around to this for three weeks and…

Manu_Sporny: haven't split the PRs out yet. So, it might be faster for us all to agree to remove both and just merge this.

Dmitri_Zagidulin: I got all right.

Dmitri_Zagidulin: Yep. is enough.

Manu_Sporny: It's purely just unless somebody else wants to raise the PR. I'd be super happy if that happened as note So Benjamin, there's one other and I'm rushing because I wanted to try to get to the threat model discussion today, but …

Manu_Sporny: we get to when we get to it. Benjamin, the last PR is this one that you've opened. output preference term section. I think we've got a bunch of thumbs up.

Benjamin_Young: Yeah, it's approved and…

Benjamin_Young: I process the comments into an additional commit.

Manu_Sporny: So this is good to merge.

Benjamin_Young: It is as far as I know.

Manu_Sporny: Okay.

Benjamin_Young: You had some feedback and tall Ted did as ever and those are all in now. Ivon did have a call out about the canonical reference to a CG spec. I think the way it's referenced now is fine and when we check again later when we move to the next phase we can update that…

Benjamin_Young: if it's required.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants