Skip to content

Fix iOS and Android CI and require Action version tags - #165

Merged
efraespada merged 3 commits into
developfrom
bugfix/164-fix-ios-swiftpm-pub-cache-integration-startup-on-develop
Oct 25, 2026
Merged

efraespada merged 3 commits into
developfrom
bugfix/164-fix-ios-swiftpm-pub-cache-integration-startup-on-develop

Conversation

@efraespada

@efraespada efraespada commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Flutter 3.47.2 can launch an iOS simulator app before its log stream is ready, lose the one-time Dart VM service URL, and wait until the watchdog expires. Develop's SwiftPM/pub-cache integration consequently built and installed the app but executed no tests.

Closes #164.

Changes

  • Backport Flutter's official simulator log-readiness fix and regression tests from flutter/flutter#193142 into a disposable, revision-checked Flutter 3.47.2 SDK. Keep the shared SDK unchanged; rebuild the private tool snapshot and remove only the job's marked directory.
  • Apply the same iOS SDK preparation to platform CI and future release-candidate validation. Preserve all four SwiftPM/CocoaPods and workspace/pub-cache variants, test assertions, simulator ownership and the 900-second watchdog.
  • Use a private Gradle home and explicitly select the CI JDK 17 for Android builds. Both legacy variants previously failed while loading Flutter's Gradle plugin, including a retry. Keep AGP 9.1/Gradle 9.3.1 and legacy AGP 8.11.1/Gradle 8.14; isolate candidate consumers separately and collect a full Gradle stack trace on configuration failure.
  • Require version tags such as @v1, @v2 and @v3 for remote Actions in workflows and composites. Replace 39 SHA references and validate all 235 current references. This follows the maintainer's explicit policy; the SHA-pinning review recommendation was dismissed on that basis.

Copilot configuration, guidance, internal workflows, verification setup, hotfix workflow and all vypdev/copilot@v3 references are unchanged.

Validation

Revision: 19c31f2603897147295b8f32ae706de2fcd890f7.

Merged normally into develop after all technical CI passed. No version changes, deployment labels, tags, releases or publication are part of this work.

@vypbot vypbot added size: XL 55% Progress: 55% labels Oct 25, 2026
@codecov-commenter

codecov-commenter commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (f37190a) to head (19c31f2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #165   +/-   ##
========================================
  Coverage    77.36%   77.36%           
========================================
  Files           14       14           
  Lines         1109     1109           
========================================
  Hits           858      858           
  Misses         251      251           
Flag Coverage Δ
cli 76.61% <ø> (ø)
platform_interface 85.71% <ø> (ø)
zstandard 88.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Oct 25, 2026
@vypbot vypbot changed the title Fix iOS integration startup with isolated Flutter log-readiness backport fix: Fix iOS SwiftPM pub cache integration startup on develop (#164) Oct 25, 2026
@vypbot
vypbot self-requested a review October 25, 2026 11:18
@vypbot vypbot added this to vypdev Oct 25, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 25, 2026
@vypbot
vypbot changed the base branch from develop to master October 25, 2026 11:18
@efraespada efraespada linked an issue Oct 25, 2026 that may be closed by this pull request
1 task done
@vypbot
vypbot changed the base branch from master to develop October 25, 2026 11:19
@vypbot

vypbot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 19c31f2.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 25, 2026
@vypbot

vypbot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: This pull request is outside the configured approval scope.
Completed: 3/3 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 19c31f260389; base: f37190aa12c9; reason: scope.

@efraespada efraespada changed the title fix: Fix iOS SwiftPM pub cache integration startup on develop (#164) Fix iOS integration startup and require Action version tags Oct 25, 2026
@vypbot vypbot added 70% Progress: 70% state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed 55% Progress: 55% labels Oct 25, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 19c31f2. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit e825984 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • high: Mutable action tags are accepted in the OIDC publishing job — .github/scripts/check_action_versions.py:34

@vypbot vypbot added state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:changes-requested Review identified changes that are required. labels Oct 25, 2026
@vypbot vypbot added state:reviewing A pull request is being reviewed. and removed state:awaiting-issue-author The next action requires more information or changes from the issue author. labels Oct 25, 2026
@vypbot vypbot added 65% Progress: 65% state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed 70% Progress: 70% state:reviewing A pull request is being reviewed. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 25, 2026
@efraespada efraespada changed the title Fix iOS integration startup and require Action version tags Fix iOS and Android CI and require Action version tags Oct 25, 2026
@efraespada
efraespada merged commit ed82526 into develop Oct 25, 2026
63 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 25, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XL state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Fix iOS SwiftPM pub cache integration startup on develop

3 participants