Skip to content

chore(ci): use shared self-hosted runners - #156

Merged
efraespada merged 16 commits into
masterfrom
feature/runner-alignment-20261023
Oct 24, 2026
Merged

efraespada merged 16 commits into
masterfrom
feature/runner-alignment-20261023

Conversation

@efraespada

@efraespada efraespada commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Aligns repository workflows with the vypdev self-hosted runners and makes native platform checks more reliable through isolated tool state and runner-specific setup. Pull requests now run native CI against master while preserving the existing platform checks and publication dry runs.

What changed

  • Routes repository workflows to the vypdev runner group and guards native PR jobs against running fork code on persistent runners.
  • Updates Flutter setup and platform-specific tooling, including ARM64 macOS runners, Android emulator preparation, Windows SDK setup, and Linux virtual displays.
  • Improves web and iOS integration setup with matched Chrome and ChromeDriver binaries, isolated simulator ownership, and targeted cleanup.
  • Keeps line coverage thresholds while handling line-only LCOV reports and preserving Codecov signature verification.
  • Excludes generated build and platform directories from Flutter analysis. Updates the stale workflow action without enabling automatic closure.

Validation

  • Workflow actionlint passes.
  • A real WebDriver probe reproduced the macOS Chrome bundle-layout failure and passed with the corrected private-copy layout; the full Flutter web integration passed with the helper.
  • Three iOS simulator ownership and failure-contract tests pass locally and in CI.
  • The rootless Xvfb setup was validated with a real X11 client as an unprivileged user on Ubuntu 24.04.
  • Local Android preparation with the Flutter SDK confirmed selection of JDK 17 and the configured Gradle limits.

Review notes

  • Native platform tests and a complete current-head review remain required before merge; fresh native Android integration is also identified as a required CI gate.
  • The ARM64 Mac runner needs full Xcode and an installed iOS Simulator runtime for iOS integration tests.

@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Oct 23, 2026
@vypbot
vypbot self-requested a review October 23, 2026 19:44
@vypbot vypbot added this to vypdev Oct 23, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 23, 2026
@vypbot

vypbot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 49cadc4.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot

vypbot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: This pull request is outside the configured approval scope.
Completed: 3/3 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 49cadc4925af; base: 86f73fd36661; reason: scope.

@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added the state:ai-processing A Copilot agent is analyzing or working on the issue or change. label Oct 23, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 49cadc4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 6b8cecf was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: The Xvfb setup downloads packages without their dependencies — .github/actions/prepare-linux-display/action.yml:17

@vypbot vypbot removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Oct 23, 2026
@vypbot vypbot added state:awaiting-issue-author The next action requires more information or changes from the issue author. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.05%. Comparing base (b28ddf1) to head (49cadc4).
⚠️ Report is 89 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #156       +/-   ##
===========================================
- Coverage   64.09%   51.05%   -13.05%     
===========================================
  Files          12       12               
  Lines         454      570      +116     
===========================================
  Hits          291      291               
- Misses        163      279      +116     
Flag Coverage Δ
cli 47.30% <ø> (-14.26%) ⬇️
platform_interface 85.71% <ø> (ø)
zstandard 76.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. and removed state:changes-requested Review identified changes that are required. state:awaiting-issue-author The next action requires more information or changes from the issue author. state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 23, 2026
@vypbot vypbot added state:ai-processing A Copilot agent is analyzing or working on the issue or change. and removed state:ai-processing A Copilot agent is analyzing or working on the issue or change. labels Oct 24, 2026
@efraespada
efraespada merged commit e2a0d57 into master Oct 24, 2026
39 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 24, 2026
@vypbot vypbot added state:verified The change has passed Copilot verification. and removed state:ready The change is ready for human approval or merge. state:awaiting-maintainer The next action requires a maintainer response or approval. labels Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:verified The change has passed Copilot verification.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants