You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ππ§βπ» - Compare navigation screenshots with original Home Assistant pixelsΒ #14
The text and icon navigation checks compare measured styles and geometry but only retain screenshots. They can miss a paint-only regression in the navigation surface. Compare decoded pixels from the built catalog against the existing independently captured Home Assistant references for both checks, with a narrow, measured tolerance where the captured platform requires it.
Reproducing the issue
Run the static Storybook tests and inspect the text and icon navigation parity reports. Both contain the original image identity and a candidate screenshot, with no pixel agreement metric. See #13 (comment).
copilot Version
3.10.7 in the installed workflow. The defect is in the ha-ui Storybook checks.
Additional context and comments
Keep the existing geometry, state and accessibility assertions and the original captures. Validate on the existing Chromium platform matrix. The change belongs on develop so promotion PR #13 receives the correction.
changed the title [-]Compare navigation screenshots with original Home Assistant pixels[/-][+]ππ§βπ» - Compare navigation screenshots with original Home Assistant pixels[/+]on Nov 5, 2026
Current status: Ready to start. No action is required from maintainers before implementation.
Locate the navigation parity checks and reference captures
Identify the text and icon Storybook checks, their independently captured Home Assistant references, and the existing Chromium platform matrix.
Add decoded-pixel comparison
Compare each built catalog screenshot with its matching reference and report a pixel agreement metric alongside the original image identity and candidate screenshot.
Set measured platform tolerances
Measure capture differences on Linux and macOS and use a narrow tolerance only where a platform requires it.
Preserve existing assertions and captures
Keep geometry, state, and accessibility assertions and retain the original reference captures.
Verify both checks across the matrix
Run the static Storybook tests on the existing Chromium platform matrix and update relevant documentation if the comparison workflow changes.
Acceptance: On every existing Chromium matrix platform, both text and icon navigation parity reports include a pixel agreement metric against the matching independent reference, and the checks pass within the measured platform tolerance while retaining their existing geometry, state, and accessibility assertions.
Need something else? Mention the bot with a question or use /copilot help.
The last estimate is retained below as history. Closure does not certify a new percentage, tests, or branch alignment.
Action required: none for this closed issue. If work continues, reopen the issue; a fresh assessment can update this same card.
Last assessment before closure (historical)
Progress: 75% β in progress
> Current status: [R1] The text and icon navigation checks compare measured styles and geometry but only retain screenshots. They can miss a paint-only regression in the navigation surface. Compare decoded pixels from the built catalog against the existing independently captured Home Assistant references for both checks, with a narrow, measured tolerance where the captured platform requires it. β Both navigation checks compare decoded candidate pixels with the matching original reference and assert zero changed pixels. Reports record raster agreement alongside existing measured style and geometry results.
[R2] Keep the existing geometry, state and accessibility assertions and the original captures. Validate on the existing Chromium platform matrix. The change belongs on develop so promotion PR #13 receives the correction. β The patches preserve the existing geometry, state, accessibility, and reference-image checks. Documentation describes pixel checks on macOS and Linux, but the supplied comparison does not establish execution across the Chromium platform matrix or branch promotion.
[R3] "acceptance": "On every existing Chromium matrix platform, both text and icon navigation parity reports include a pixel agreement metric against the matching independent reference, and the checks pass within the measured platform tolerance while retaining their existing geometry, state, and accessibility assertions." β The source adds a pixel agreement metric and a zero-changed-p
[untrusted content truncated]
Next: [R2] Keep the existing geometry, state and accessibility assertions and the original captures. Validate on the existing Chromium platform matrix. The change belongs on develop so promotion PR #13 receives the correction. β Verify both checks on every existing Chromium matrix platform and confirm the correction is on develop for promotion PR #13.
[R3] "acceptance": "On every existing Chromium matrix platform, both text and icon navigation parity reports include a pixel agreement metric against the matching independent reference, and the checks pass within the measured platform tolerance while retaining their existing geometry, state, and accessibility assertions." β Obtain independent results confirming both reports include pixel agreement against matching references and pass on every existing Chromium matrix platform.
Activity
[-]Compare navigation screenshots with original Home Assistant pixels[/-][+]ππ§βπ» - Compare navigation screenshots with original Home Assistant pixels[/+]vypbot commentedon Nov 5, 2026
Implementation plan
Acceptance: On every existing Chromium matrix platform, both text and icon navigation parity reports include a pixel agreement metric against the matching independent reference, and the checks pass within the measured platform tolerance while retaining their existing geometry, state, and accessibility assertions.
Need something else? Mention the bot with a question or use
/copilot help.vypbot commentedon Nov 5, 2026
Issue closed β historical progress
Current status: closed as completed.
The last estimate is retained below as history. Closure does not certify a new percentage, tests, or branch alignment.
Action required: none for this closed issue. If work continues, reopen the issue; a fresh assessment can update this same card.
Last assessment before closure (historical)
vypbot commentedon Nov 5, 2026
Issue closed: synchronization recommendation retired
No branch synchronization is required for this closed issue.
The previous recommendation is historical. Issue closure does not certify that the branches are synchronized.