Repository navigation
Persist independent member profiles and migrate SQLite to schema9 - #24
Merged
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
November 2, 2026 14:09
vypbot
reviewed
Nov 2, 2026
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on4e59e04. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit e129e76 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Profile foreign keys reference a non-unique member key —
backend/src/domus/infrastructure/sqlite_member_profile_schema.py:8 - low: Incorrect Git blob ID prevents verifying the cited source —
specs/household-administration-integration.md:42
Bugbot: review complete
|
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21. Adds the schema9 persistence foundation for the retained household administration workspace after the actual PR22 schema8 merge.
Public aliases and owner-private preferences now have separate scoped repositories and independent revisions. Creating a member writes both domain-defined defaults atomically; membership updates preserve them. Strict decoding, compare-and-swap, composite foreign keys, explicit non-null primary keys and independent checkpoint inspection reject invalid or missing state. Supported schema1..8 upgrades preserve historical inputs and original operation evidence; migration or late SQL failure rolls back atomically.
Validation on e129e76: 4,105 backend executions; all 140 authored modules, 9,919 statements and 2,822 branches at 100% supported coverage globally and per module, with independent audit. The 74 focused executions cover genuine migrations, corruption, real concurrent writers and generation restoration. Types, Ruff, 56 package/architecture tests, 38 Node policy tests and documentation links pass. Every module matches the new wheel. Original pinned SDD validation passes with all seven upstream policy modules byte-verified; the 72-case owner remains unchanged.
CI now builds an immutable checksum-pinned complete schema8 backend/frontend as well as both current CPU images. Four exact image-script controls pass on the host for fresh/schema8 native and standalone owned runtimes. Actual image upgrade/refusal/restoration and every product suite pass on head4e59e04 in CI41460987862, aggregate125333262774. Native41460987851 completes4/4 partitions with complete context and zero candidate/published/open/reopened/verification-required findings. Its dismissed2 projection includes one corrected valid owner-blob citation and one proved FK false positive; these are not two false positives. Host execution remains distinct from actual image acceptance.
This is the schema9 storage checkpoint for #21. All unfinished contracts and all72 product journeys are explicitly retained in #25 before merge; lifecycle closure does not certify complete administration acceptance. Current-authorized profile/preference commands and original-result privacy, HA metadata, the separate administration journal, the full EN/ES workspace and all 72 product journeys remain required. The recurrence/calendar continuation remains #23. Reported Copilot-only progress scope failure828/reference2434d6cb-3847-4a2d-903f-ae0d259b80bf remains distinct from green product CI and no-findings review, under the owner's standing exception. Installed Edge.5 and Copilot are unchanged. A nonexistent verification command in the generated SDD was reproduced and reported as vypdev/copilot#858; the Domus-owned draft now names the actual original pinned validation outcome. See docs/household-administration-migration.md and docs/evidence/household-administration.json for source proofs, results and limits.