ci: remove the termlens-cli publish bootstrap, now that it is unnecessary - #303
Merged
Conversation
…sary v0.10.1 published termlens-cli through Trusted Publishing, which is the proof the bootstrap was waiting for. The workflow, its zizmor exemption and the "not linked yet" warning in RELEASING.md all go with it. The teardown deliberately ran after a release rather than as soon as the crates.io link existed: this workflow was the only path that could publish termlens-cli without OIDC, and removing a fallback before the mechanism replacing it has actually run is the wrong order. RELEASING.md keeps the recipe for the next new crate, with that ordering stated. The `CARGO_REGISTRY_TOKEN` secret is the owner's to delete; nothing in the repository reads it any more. Refs #255 Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.10.1 published
termlens-clithrough Trusted Publishing (run 34211967168), which is the proof the bootstrap was waiting for. Removing:.github/workflows/publish-cli.ymluse-trusted-publishingexemption in.github/zizmor.ymldocs/RELEASING.md, which now records both crates as linked and states plainly that no secret is stored for publishingThe teardown ran after a release rather than as soon as the link existed, on purpose: that workflow was the only path that could publish
termlens-cliwithout OIDC, and removing a fallback before its replacement has actually run is the wrong order. RELEASING.md keeps the recipe for the next new crate with that ordering written into it.Yours: delete the
CARGO_REGISTRY_TOKENrepository secret — nothing in the repo reads it any more.Refs #255