Skip to content

fix: apply live statistics statusbar layout settings - #210

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/live-statusbar-layout-settings
Open

fix: apply live statistics statusbar layout settings#210
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/live-statusbar-layout-settings

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • Rebuild the statistics status bar item when todo.statistics.statusbar.alignment or todo.statistics.statusbar.priority changes.
  • Dispose the previous item and reapply its current visibility, text, tooltip, color, and command through the normal update path.
  • Add a regression test that exercises the live configuration transition and document the fix in the unreleased changelog.

Verification

  • RED: TS_NODE_TRANSPILE_ONLY=1 npx mocha --no-config -r ts-node/register test/statusbar-layout-settings.spec.ts --exit — failed on the untouched behavior with 0 passing and an expected length-of-2 assertion failure.
  • GREEN: same focused command — 1 passing.
  • TS_NODE_TRANSPILE_ONLY=1 npm test — 135 passing.
  • npm run compile — passed.
  • npm run format:check — passed.
  • git diff --check upstream/develop...HEAD — passed.

Risk

  • Low: the change is limited to the statistics status bar's existing configuration update path and disposes only the replaced VS Code item.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev vycdev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The live-layout implementation currently does not compile against the integrated branch.

_initItem() {
const layout = this._getLayout();

this.layout = layout;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout is never declared as a class property. On current develop, both npm test and TypeScript compilation fail with TS2339 at this assignment and the reads in _updateLayout. Add the field (with an appropriate layout type) and rerun the full suite; I reproduced two failing statusbar specs after integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants