Skip to content

fix: isolate rejection observer failures - #209

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/ignore-rejection-handler-errors
Open

fix: isolate rejection observer failures#209
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/ignore-rejection-handler-errors

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • keep successful mapFulfilled results when an optional rejection observer itself throws
  • prevent secondary logging/reporting failures from rejecting the aggregate operation
  • add behavioral regression coverage and document the fix

TDD evidence

  • Untouched-base RED: TS_NODE_TRANSPILE_ONLY=1 npm test -- --grep "rejection handler throws" failed because Error: logging failed escaped from the observer and rejected the whole batch.
  • GREEN: the same focused command passed after isolating observer failures.

Verification

  • TS_NODE_TRANSPILE_ONLY=1 npm test — passed, 135 tests
  • npm run compile — passed
  • npm run format:check — passed
  • git diff --check upstream/develop...HEAD — passed

Risk

Low. Mapper failures were already intentionally omitted; this only prevents the optional rejection observer from changing that aggregate contract. Successful result ordering is unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant