fix: ignore dependency tags on non-task lines - #208
Open
vycdev2 wants to merge 1 commit into
Open
Conversation
vycdev
requested changes
Aug 10, 2026
vycdev
left a comment
Owner
There was a problem hiding this comment.
This behavior is correct, but the new dependency on the full Todo item graph breaks the existing integrated test suite.
| import * as _ from 'lodash'; | ||
| import * as vscode from 'vscode'; | ||
| import Consts from '../consts'; | ||
| import { Todo } from '../todo/items'; |
Owner
There was a problem hiding this comment.
Importing ../todo/items here pulls the entire item/Consts graph into dependency_index; after integrating current develop, npm test now fails both existing dependency-index lifecycle tests during module compilation. This utility already has pure status/regex helpers available on develop, so classify Consts.regexes.todo through one of those instead of importing the concrete Todo class, and run the full suite (not only the new focused test).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@id(...)and@depends(...)references only on actual Todo task linesTDD evidence
TS_NODE_TRANSPILE_ONLY=1 npm test -- --grep "Dependency index task data flow"failed because the index contained the comment-onlynote-onlytarget.Todo.is.Verification
TS_NODE_TRANSPILE_ONLY=1 npm test— passed, 135 testsnpm run compile— passednpm run format:check— passedgit diff --check upstream/develop...HEAD— passedRisk
Low. Dependency tag parsing is unchanged for task lines; only non-task lines are excluded before reference extraction.
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.