Skip to content

fix: parse estimates before terminal punctuation - #198

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/estimate-terminal-punctuation-1786315277
Open

fix: parse estimates before terminal punctuation#198
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/estimate-terminal-punctuation-1786315277

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • Recognize compact estimate tags when sentence-ending punctuation follows the duration.
  • Keep strict boundaries so estimate-like prefixes inside longer tokens remain ignored.
  • Add regression coverage for compact and explicit estimate forms and document the user-visible statistics fix.

Verification

  • Focused estimate regression test was confirmed RED before implementation and GREEN afterward.
  • npm install — passed with existing deprecation and vulnerability warnings.
  • npx mocha -r ts-node/register test/estimate.spec.ts --exit — passed.
  • npm test — passed (135 tests).
  • npm run compile — passed.
  • npm run format:check — passed.
  • git diff --check — passed.

Risk

Low. Matching expands only at a terminal punctuation boundary; longer estimate-like tokens such as @2h.foo remain rejected.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant