fix: handle math.gcd int64 minimum - #84
Open
vycdev2 wants to merge 1 commit into
Open
Conversation
Owner
|
The unsigned-magnitude GCD fix is correct in isolation and its focused tests passed, but it now conflicts with the merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math.gcdwith unsigned magnitudes soint64minimum inputs work when the result is representable2^63and cannot fitint64Verification
cargo test -q -p jett_comptime builtin_math_gcd— passed (2 tests)cargo test -q -p jett_driver --test fixture_suite math_gcd_reports_unrepresentable_result— passed (1 test)cargo build— passedcargo test -q— passed (full workspace suite)cargo fmt --check— passedcargo run -q -p jett_cli -- format --check tests/runtime_fail/math_gcd_int64_min.jett— passedgit diff --check— passedRisk
math.gcdinteger magnitude handling and adds boundary regressions.This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.